Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add wf to automatically build controller image #50

Merged
merged 1 commit into from
Oct 9, 2024
Merged

🌱 Add wf to automatically build controller image #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/build-images-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
name: build-images-action

permissions:
contents: read

on:
push:
branches:
- 'main'
- 'release-*'
tags:
- 'v*'

jobs:
build_controller:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we expecting to have many jobs here? If not, then I'd probably not use controller in naming, but operator, or ISO (like IPAM) as more descriptive.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be more images coming, based on what I found on the Makefile. IMO operator is not more descriptive though, ISO might be, but it's not yet a familiar acronym yet, at least for me. controller is, therefore, more suitable, as anyone could understand what it builds from the name. This is anyway just the name of the job, not the image name.

name: Build Ironic-standalone-operator container image
if: github.repository == 'metal3-io/ironic-standalone-operator'
uses: metal3-io/project-infra/.github/workflows/container-image-build.yml@main
with:
image-name: 'ironic-standalone-operator'
pushImage: true
secrets:
QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }}
QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
Loading