Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Сomprehensive testing of references and term's source #129

Open
2 tasks done
Intelligent2013 opened this issue Mar 23, 2022 · 2 comments
Open
2 tasks done

Сomprehensive testing of references and term's source #129

Intelligent2013 opened this issue Mar 23, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Mar 23, 2022

To catch all issues like https://github.com/metanorma/metanorma-bsi/issues/111 and relaton/relaton-bsi#14:

  • prepare test adoc document with all tags std and tbx:source from available sts xml (encode as two-column table - 'expected' and 'result')
  • generate pdf and find the differences between expected and result values.
@Intelligent2013 Intelligent2013 added the enhancement New feature or request label Mar 23, 2022
@Intelligent2013 Intelligent2013 self-assigned this Mar 23, 2022
@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Mar 24, 2022

Adoc for testing:

There are a few categories of warnings WARNING: no match found:

  • [relaton-bsi] WARNING: no match found online for BS ISO 56003:2019:2019 (BS ISO 56003:2019: duplicate year in warning relaton/relaton-bsi#15)
  • [relaton-bsi] WARNING: no match found online for BS 7273 (no document at BSI shop)
  • [relaton-cen] WARNING: no match found online for EN 12973:2000
    [relaton-cen] (There was no match for 2000, though there were matches found for 2020.)
  • [relaton-iso] WARNING: no match found online for ISO 22442. The code must be exactly like it is on the standards website.
    [relaton-iso] If you wanted to cite all document parts for the reference, use "ISO 22442 (all parts)".

@Intelligent2013
Copy link
Contributor Author

Intelligent2013 commented Mar 25, 2022

Found differences between source (expected) and rendered references.

In references (STS element std):

  • prefixed text in the source
    • Annex 5, exclusion of 7.3 of EN ISO 13485 vs CEN EN ISO 13485:2016, Annex 5=exclusion=of=7.3
    • Annex V, exclusion of 7.3 from EN ISO 13485 vs CEN EN ISO 13485:2016, Annex V=exclusion=of=7.3=from
    • Annex VI, exclusion of 7.3, 7.5.1 and 7.5.2 from EN ISO 13485 vs CEN EN ISO 13485:2016, Annex VI=exclusion=of=7.3=7.5.1 and 7.5.2=from

The reason: wrong markup in the source STS xml - text placed inside std:

<td style="padding:0 5.20px 0 5.20px;">For <std>Annex 5, exclusion of 7.3 of <std-ref>EN ISO 13485</std-ref>
	</std> is permitted</td>
<td style="padding:0 5.20px 0 5.20px;">For <std>Annex V, exclusion of 7.3 from <std-ref>EN ISO 13485</std-ref>
	</std> is permitted</td>
<td style="padding:0 5.20px 0 5.20px;">For <std>Annex VII, exclusion of 7.3 from <std-ref>EN ISO 13485</std-ref>
	</std> is permitted</td>

Term's sources (STS element tbx:source):

  1. :— after std-ref
<tbx:note>See also <std>
<std-ref>IEC 62366</std-ref>:—, Annexes B and D.1.3</std>.</tbx:note>
  1. :— after number in tbx:source
<tbx:source>IEC 62366:— <xref ref-type="fn" rid="fn_2">
  1. : after number and after std-ref.
<ref id="biblref_30">
	<label>[30]</label>
	<std>
		<std-ref>IEC 62366:</std-ref>— <xref ref-type="fn" r
  • test case 114
    ISO/IEC Guide 2:2004, definition 1.7 [2]
    ISO/IEC Guide 2:2004

  • test case 125 - double dash
    ISO/IEC Guide 99:2007, 2.20, modified — The term name has been simplified and the notes omitted.
    ISO/IEC Guide 99:2007, 2.20, modified – — The term name has been simplified and the

  • test case 180
    ISO 9000:2005, definition 3.4.1
    definition 3.4.1

  • test case 211
    Modified from ISO/DIS 11139:2017
    Modified from ISO/DIS 11139:2017 [60]

  • test case 212
    NATURAL CAPITAL COMMITTEE [32]
    NATURAL CAPITAL COMMITTEE

  • test case 213
    Oxford English Dictionary, modified
    Oxford English Dictionary [61], modified

  • test case 214 (issue: https://github.com/metanorma/metanorma-bsi/issues/127)
    PAS 7340:2020, 2.10
    [62], 2.10

  • test case 215
    PAS 7340:2020, 2.17, modified
    modified [62]

  • wrong bibliography item

[bibliography
== Bibliography

  • [[[BS_5839_1_2013,hidden()]]
  • wrong sts-> adoc conversion (fixed already in mnconvert)
=== test case 76

Examples of scope 3 activities are extraction and production of purchased materials, transportation of purchased fuels and use of sold products and services.

[.source]
<<>>

Intelligent2013 added a commit that referenced this issue Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

1 participant