-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BSI data source issue: Shop only returning results Amendment supplemented results for "BS EN ISO 14044:2006" #12
Comments
The same is happening for PAS 2035/2030:2019 : https://shop.bsigroup.com/search?query=PAS+2035%3A2019&status=Current&type=products&page=1 I think we're going to need to be able to truncate "+..." in document retrieval. |
@opoudjis please be careful about this case |
I've asked BSI about this problem pending a reply. |
From @opoudjis
In fact, I was able to search for it on the webshop: Then I click on that link with the most similar document identifier: And then "Document History": The whole list of superseded documents are there! They are just not for sale, but they exist! |
@andrew2net and I found out that a GraphQL JSON query is used to fetch Document History:
This gives: [{
"level": 3,
"nodes": [{
"standard": {
"assetId": "01-4190858983",
"title": "Improving the energy efficiency of existing buildings. Specification for installation process, process management and service provision",
"primaryDesignator": "PAS 2030:2012 Edition 2",
"status": "Withdrawn",
"handle": "improving-the-energy-efficiency-of-existing-buildings-specification-for-installation-process-process-management-and-service-provision-1"
},
"parentAssetIds": ["01-1721332204"]
}]
}, {
"level": 2,
"nodes": [{
"standard": {
"assetId": "00-4175954925",
"title": "Improving the energy efficiency of existing buildings Specification for installation process, process management and service provision",
"primaryDesignator": "PAS 2030:2014",
"status": "Withdrawn",
"handle": "improving-the-energy-efficiency-of-existing-buildings-specification-for-installation-process-process-management-and-service-provision-6"
},
"parentAssetIds": ["01-4190858983"]
}]
}, {
"level": 1,
"nodes": [{
"standard": {
"assetId": "00-8691469210",
"title": "Specification for the installation of energy efficiency measures (EEM) in existing buildings",
"primaryDesignator": "PAS 2030:2017",
"status": "Withdrawn",
"handle": "specification-for-the-installation-of-energy-efficiency-measures-eem-in-existing-buildings"
},
"parentAssetIds": ["00-4175954925"]
}]
}, {
"level": 0,
"nodes": [{
"standard": {
"assetId": "00-3492300904",
"title": "Specification for the installation of energy efficiency measures in existing dwellings and insulation in residential park homes",
"primaryDesignator": "PAS 2030:2019+C2:2021",
"status": "Withdrawn",
"handle": "specification-for-the-installation-of-energy-efficiency-measures-in-existing-dwellings-and-insulation-in-residential-park-homes"
},
"parentAssetIds": ["00-8691469210"]
}]
}, {
"level": -1,
"nodes": [{
"standard": {
"assetId": "00-8446111360",
"title": "Retrofitting dwellings for improved energy efficiency. Specification and guidance",
"primaryDesignator": "PAS 2035/2030:2019+A1:2022",
"status": "Current",
"handle": "retrofitting-dwellings-for-improved-energy-efficiency-specification-and-guidance-3"
},
"parentAssetIds": ["00-3492300904"]
}]
}]
|
Actually I realized that the endpoint is just a Shopify GraphQL endpoint. If we have some documentation to build a proper query for the |
UPDATE: the BSI shop does this:
And actually, even in the Document History, we cannot find the "standalone" PAS 2030:2019 document without the C2. BSI responded that this is because without the "Corrigendum" the document is "wrong", so they only have that entry. Then we will have to make do with this entry. i.e. we have no choice but to return "PAS 2030:2019+C2:2021" if our query is "PAS 2030:2019". Locally, perhaps we can drop the "+C2:2021" portion. |
As @opoudjis this is probably the step we have to take. |
Or substitute it with the previous corrigendum, as required. Ugh. |
There are another examples of queries (from metanorma/mnconvert#129):
|
https://github.com/metanorma/metanorma-bsi/issues/132 is the same set of issues. |
@ronaldtse are we talking about truncating "+..." for all the BSI documents? |
@andrew2net we have to offer both identifiers (docid) for this one entry:
|
A search for "BS EN ISO 14044:2006" only returns the document references that already have Amendments attached. That works for shopping (a buyer would want to get the free amendment) but is not appropriate for fetching references.
We need to ask BSI how we can obtain such reference.
Originally posted by @ronaldtse in #11 (comment)
The text was updated successfully, but these errors were encountered: