refactor binary expression parsing. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| , '--': CS.PostDecrementOp | ||
| }, | ||
|
|
||
| precedenceHierarchy = |
There was a problem hiding this comment.
I guess I should probably change this to index by symbols like the others, in case (for example) we want and and && to be at different precedence levels one day.
The assignments are all particular about their LHS, so it's not appropriate to treat them as any old binary operator. And since seqs are below assigns in precedence order, they'll stay where they are as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112. Chained comparison handling really muddied up
foldBinaryExpr, unfortunately. Performance appears to have been improved by only around 5%. Still, the grammar itself is much smaller and DRY-er. Assignment and compound assignments still need to be pulled intofoldBinaryExpr, but they should be much easier than chained comparison handling.