Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor binary expression parsing #112

Closed
michaelficarra opened this issue Dec 8, 2012 · 1 comment · Fixed by #166
Closed

refactor binary expression parsing #112

michaelficarra opened this issue Dec 8, 2012 · 1 comment · Fixed by #166
Labels
enhancement
Milestone
2.0

Comments

@michaelficarra
Copy link
Owner

As suggested by someone with more PEG experience than me at YOW!2012 and recently implemented in Esprima. Should provide a nice speedup for complex expressions and deeply nested parentheses.

Related: ariya/esprima@c7d1052e5a
@michaelficarra michaelficarra mentioned this issue Jan 14, 2013
Open
michaelficarra added a commit that referenced this issue Feb 6, 2013
@michaelficarra
rewrite prefixExpression parser rule using strategy from #112
5d466aa
@michaelficarra
Copy link
Owner Author

I'm making good progress on this. See the GH-112 branch. I just have to switch out all the binary expression rules with one rule that parses a list of arbitrary binary expressions and then fold them using the precedence table.

This was referenced Feb 11, 2013
Merged
Open
michaelficarra added a commit that referenced this issue Feb 18, 2013
@michaelficarra
Merge branch 'GH-112'
673ca7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

refactor binary expression parsing. michaelficarra/CoffeeScriptRedux
1 participant
@michaelficarra