Add two more (and correct others) Shovel properties #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dest-application-properties and dest-properties are map instead of string
ChunyiLyu
force-pushed
the
shovel-properties
branch
2 times, most recently
from
6f9d73a
to
775a5f2
Compare
- dest-queue-args, src-queue-args, src-consumer-args, and dest-message-annotations - other "missing" parameters 'add-timestamp-header' and 'publish-properties' are not added because their equivalent 'dest-add-timestamp-header' and 'dest-publish-properties' are already present
ChunyiLyu
force-pushed
the
shovel-properties
branch
from
775a5f2
to
c3b509a
Compare
michaelklishin
approved these changes
May 18, 2023
michaelklishin
changed the title
|
@ChunyiLyu thank you. I've tagged a new release, |
ChunyiLyu
added a commit
to rabbitmq/messaging-topology-operator
that referenced
this pull request
May 19, 2023
- destApplicationProperties, destPublishProperties and destPublishProperties should be map instead of string. See related rabbit-hole changes: michaelklishin/rabbit-hole#262 michaelklishin/rabbit-hole#268
ChunyiLyu
added a commit
to rabbitmq/messaging-topology-operator
that referenced
this pull request
May 19, 2023
- destApplicationProperties, destPublishProperties and destPublishProperties should be map instead of string. See related rabbit-hole changes: michaelklishin/rabbit-hole#262 michaelklishin/rabbit-hole#268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #262
dest-application-propertiesanddest-propertiesto maps from strings.See: https://github.com/rabbitmq/rabbitmq-server/blob/main/deps/rabbitmq_shovel/src/rabbit_shovel_parameters.erl#L156
https://github.com/rabbitmq/rabbitmq-server/blob/main/deps/rabbitmq_shovel/src/rabbit_shovel_parameters.erl#L172.
src-queue-args,src-consumer-args,dest-application-propertiesanddest-message-annotations.add-timestamp-headerandpublish-propertiesare not added since the preferred parametersdest-add-timestamp-headeranddest-publish-propertiesare already there.When we release the next major and drop support for older RMQ, we can remove
add-forward-headers,delete-after, andprefetch-countfrom shovel definition.