Correct shovel properties type and expose more shovel configurations in CRD

[ChunyiLyu]

This closes #614

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes

Summary Of Changes

• destApplicationProperties, destProperties and destPublishProperties should be map instead of string. See related rabbit-hole changes:
  For Shovel changed dest-publish-properties to map michaelklishin/rabbit-hole#262
  Add two more (and correct others) Shovel properties michaelklishin/rabbit-hole#268

• expose dest-message-annotations and src-consumer-args in shovel CRD.

Reasons not to exposesrc-queue-args and dest-queue-args for now <- created queues from with shovel won't be deleted when shovel is removed. I'm unsure if we want to encourage such use case. Most importantly queue creation is already possible with queues.rabbitmq.com. We could expose them if we get specific user request in the future.

• add shovel validation
  Accepted protocols for source and destination are amqp10 and amqp091. If empty the plugin defaults to
  amqp091: https://github.com/rabbitmq/rabbitmq-server/blob/f83ed85fedadc3dc29595d0b0d109db0b8c67f17/deps/rabbitmq_shovel/src/rabbit_shovel_parameters.erl#L489-L500
  When any protocol is set to amqp10, address needs to be provided.
  plugin validation on destination: https://github.com/rabbitmq/rabbitmq-server/blob/f83ed85fedadc3dc29595d0b0d109db0b8c67f17/deps/rabbitmq_shovel/src/rabbit_shovel_parameters.erl#L153
  plugin validation on source: https://github.com/rabbitmq/rabbitmq-server/blob/main/deps/rabbitmq_shovel/src/rabbit_shovel_parameters.erl#L123

• add a shovel system that uses amqp10 protocol for source and destination. Configurations are different for amqp10 and amqp091. By default, shovel plugin assumes amqp10 protocol. Previous system test only test amqp091 related properties.

Conversion webhook and why we don't need it

This PR changes Shovel CRD and it's a breaking change. However, I don't believe a conversion web hook is necessary because if you were to set any of these three properties currently, reconciliation fails.

Example shovels.rabbitmq.com manifest:

apiVersion: rabbitmq.com/v1beta1
kind: Shovel
metadata:
  name: example
spec:
  name: example
  uriSecret:
    name: shovel-secret
  srcQueue: "source-queue"
  destQueue: "destination-queue"
  destApplicationProperties: "{test: test}"
  destPublishProperties: "yo: yo"
  destProperties: "{work: work}"
  rabbitmqClusterReference:
    name: test

Reconciliation fails with rabbit-hole validation error status code 400 returned from RMQ server, e.g.

{"level":"error","ts":"2023-05-18T10:19:30Z","msg":"Reconciler error","controller":"shovel","controllerGroup":"rabbitmq.com","controllerKind":"Shovel","Shovel":{"name":"example","namespace":"rabbitmq-system"},"namespace":"rabbitmq-system","name":"example","reconcileID":"48f10d23-9c45-4dfa-aa47-f605a555e3b9","error":"Error 400 (bad_request): Validation failed\n\nUnrecognised terms [{<<\"dest-application-properties\">>,<<\"{test: test}\">>}] in example\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235"}

{"level":"error","ts":"2023-05-18T10:23:46Z","msg":"Reconciler error","controller":"shovel","controllerGroup":"rabbitmq.com","controllerKind":"Shovel","Shovel":{"name":"example","namespace":"rabbitmq-system"},"namespace":"rabbitmq-system","name":"example","reconcileID":"a645dbb9-0fbe-4197-bc7d-6d48dd908e74","error":"Error 400 (bad_request): Validation failed\n\ndest-publish-properties not a list <<\"{yo: yo}\">>\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235"}

{"level":"error","ts":"2023-05-18T10:24:25Z","msg":"Reconciler error","controller":"shovel","controllerGroup":"rabbitmq.com","controllerKind":"Shovel","Shovel":{"name":"example","namespace":"rabbitmq-system"},"namespace":"rabbitmq-system","name":"example","reconcileID":"5145e11a-1e8f-4052-ba78-5fae5b5f1beb","error":"Error 400 (bad_request): Validation failed\n\nUnrecognised terms [{<<\"dest-properties\">>,<<\"key\">>}] in example\n","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235"}

So there can't be an existng shovels.rabbitmq.com with these fields set therefore there is nothing for us to convert from.

[MirahImage]

My only suggestion would be that we should consider providing an example using this new functionality.

I agree with the assessment that we don't need a conversion webhook, since the old functionality was actually broken and non-functional.