Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ApiServerPort to available AirSim settings #3196

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Add ApiServerPort to available AirSim settings #3196

merged 2 commits into from
Apr 19, 2021

Conversation

wangwwno1
Copy link
Contributor

The original docs omit the "ApiServerPort" option - an option enable the user to modify the default rpc port (41451) used by airsim.

This PR will fix it.

@wangwwno1 wangwwno1 changed the title Add default ApiServerPort setting to description Add ApiServerPort to available AirSim settings Dec 8, 2020
rajat2004
rajat2004 reviewed Dec 10, 2020
View reviewed changes
Copy link
Contributor

@rajat2004 rajat2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Along with this, I feel adding a small description of the parameter would be very useful

@wangwwno1
Copy link
Contributor Author

wangwwno1 commented Dec 11, 2020 •
edited
Loading

Thanks for this! Along with this, I feel adding a small description of the parameter would be very useful

@rajat2004
Extra description added below the descriptiton of LocalHostIp Setting.

@ahmed-elsaharti ahmed-elsaharti mentioned this pull request Feb 16, 2021
Open
@jonyMarino
Copy link
Collaborator

@wangwwno1
Thanks for contributing!

@jonyMarino jonyMarino merged commit 35e0035 into microsoft:master Apr 19, 2021
@wangwwno1 wangwwno1 deleted the patch-1 branch April 20, 2021 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajat2004 rajat2004 rajat2004 left review comments

Assignees
No one assigned
Labels
doc update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangwwno1 @jonyMarino @rajat2004