Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Dialog name to Begin Dialog action, when creating a new dialog from within a Begin Dialog action #1144

Closed
yochay opened this issue Oct 20, 2019 · 1 comment
Closed

Set Dialog name to Begin Dialog action, when creating a new dialog from within a Begin Dialog action #1144

yochay opened this issue Oct 20, 2019 · 1 comment
Assignees
@alanlong9278
Labels
Area: Form Editor P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019 Type: Bug Something isn't working

Comments

@yochay
Copy link
Contributor

yochay commented Oct 20, 2019

Describe the bug / To Reproduce

  1. Add a Begin Dialog action
  2. From the Begin Dialog action, create a new dialog
  3. Results in a new dialog, which you can edit normally.
  4. However, the newly created dialog (setp Init integration with form-editor #2) doesn't get assigned to the Begin Dialog steps, unless specifically (manually) setting the new dialog.

Expected behavior

The newly created dialog should be the value of the Begin Dialog action and being automatically set.
@yochay yochay added the Needs-triage A new issue that require triage label Oct 20, 2019
@hibrenda hibrenda added Area: Form Editor Type: Enhancement and removed Needs-triage A new issue that require triage labels Oct 21, 2019
@hibrenda hibrenda added the R7 Release 7 - December 10th, 2019 label Oct 24, 2019
@cwhitten cwhitten added Type: Bug Something isn't working P0 Must Fix. Release-blocker labels Nov 6, 2019
@alanlong9278
Copy link
Contributor

alanlong9278 commented Nov 19, 2019 •
edited
Loading

I have tried to reproduce the bug, but got the expected behavior. Is the behavior shown in the following gif correct? @yochay @a-b-r-o-w-n
beginDialog

@alanlong9278 alanlong9278 mentioned this issue Nov 19, 2019
Merged
9 tasks
alanlong9278 added a commit that referenced this issue Nov 20, 2019
@alanlong9278
fix #1144
d543d03
@alanlong9278 alanlong9278 mentioned this issue Nov 20, 2019
Merged
9 tasks
alanlong9278 added a commit that referenced this issue Nov 21, 2019
@alanlong9278
fix #1144
cc6c55c
@a-b-r-o-w-n a-b-r-o-w-n mentioned this issue Nov 21, 2019
Closed
7 tasks
a-b-r-o-w-n pushed a commit that referenced this issue Nov 25, 2019
@alanlong9278 @a-b-r-o-w-n
fix: dialog name incorrect when creating new dialog in form editor (#…
01d70e4 
…1605)

* fix #1144

* fix flicker when jumping into the new dialog

* do not render dialog when hidden

* invoke onCreateDialogComplete callback async

* delay navigation by 500ms after creating dialog from form

* convert dialog wrapper and new dialog modal to typescript

* set up tests to allow for `@app` path mapping

* add test for dialog wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanlong9278 alanlong9278

Labels
Area: Form Editor P0 Must Fix. Release-blocker R7 Release 7 - December 10th, 2019 Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yochay @cwhitten @a-b-r-o-w-n @alanlong9278 @hibrenda