-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dialog name incorrect when creating new dialog in form editor #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
November 20, 2019 10:36
alanlong9278
changed the title
Fix: dialog name incorrect when creating new dialog in form editor
fix: dialog name incorrect when creating new dialog in form editor
Nov 21, 2019
alanlong9278
force-pushed
the
julong/beginDialog
branch
from
November 21, 2019 07:24
0a16603
to
010afb9
Compare
a-b-r-o-w-n
requested changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see a flicker when creating a dialog from the form.
a-b-r-o-w-n
approved these changes
Nov 25, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrong behavior
the
BeginDialog
action can not get the dialog name after the user create a new one from the form. But there is a newbeginDialog
action with the dialog name in the new dialog trigger steps.root cause
in
createDialogBase
function, it jumps to new dialog after creating the dialog, but the operation that setting the dialog name to the oldbeginDialog
action is in thecreateDialog
promisethen
function. So the operation in formEditor takes place in the new dialog page.Solution
Move
navTo
function fromcreateDialogBase
toformEditor
function.createDialogBase
just deals with the data logic.Task Item
closes #1144
Type of change
Please delete options that are not relevant.
Checklist
Screenshots