fix: Create bot from scratch may create a non-empty bot #1796

liweitian · 2019-12-23T08:22:08Z

Description

when the state templateId is set. Create a bot from scratch will use that templateId. But it should be emptyBot.

Task Item

Closes #1814

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

I have added tests that prove my fix is effective or that my feature works
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

github-actions · 2019-12-23T08:32:54Z

Coverage remained the same at 42.853% when pulling 5f587f7 on liweitian/fixbug into 52c46aa on master.

boydc2014 · 2019-12-27T07:14:11Z

Composer/packages/client/src/CreationFlow/CreateOptions/index.js

@@ -72,10 +72,10 @@ export function CreateOptions(props) {

  const handleJumpToNext = () => {
    if (option === 'Create from template') {
-      if (template === null) onNext(templates[0]);
+      if (template === null) onNext(templates[1].key);


let's make it clear by not using a magic number.

probably explicitly say emptyBotId = templates[1].key

And please investigate, when this template is null, why not we default having a choice set for user.

@lei9444

### 01-27-2020 #### Added - feat: enrich prebuilt memory paths and add user defined memory paths ([#1868](#1868)) ([@lei9444](https://github.com/lei9444)) - feat: Language-Understanding LSP ([#1711](#1711)) ([@cosmicshuai](https://github.com/cosmicshuai)) - feat: lu shell api ([#1810](#1810)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: Start Botproject runtime in bot folder ([#1672](#1672)) ([@VanyLaw](https://github.com/VanyLaw)) - feat: Schema-driven visual editor - migrates 15 simple types ([#1811](#1811)) ([@yeze322](https://github.com/yeze322)) - feat: Update OnConversationUpdate actions ([#1794](#1794)) ([@luhan2017](https://github.com/luhan2017)) - feat: Update LG and built in expression functions in LSP ([#1790](#1790)) ([@Danieladu](https://github.com/Danieladu)) - feat: Add dynamic choices to Choice Prompt ([#1777](#1777)) ([@tdurnford](https://github.com/tdurnford)) - feat: update ui for new schema ([#1775](#1775)) ([@alanlong9278](https://github.com/alanlong9278)) - feat: lu all up view ux enhancement ([#1879](#1879)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: add autoClosingPairs for lg editor ([#1789](#1789)) ([@cosmicshuai](https://github.com/cosmicshuai)) #### Fixed - fix: update the lg content to store when editor editing ([#1884](#1884)) ([@lei9444](https://github.com/lei9444)) - fix: Aligned elements in prompt settings ([#1893](#1893)) ([@tdurnford](https://github.com/tdurnford)) - fix: remove label from validations ([#1891](#1891)) ([@tdurnford](https://github.com/tdurnford)) - fix: Undo / redo behavior on LG resources ([#1813](#1813)) ([@lei9444](https://github.com/lei9444)) - fix: botproject build script powershell version limit ([#1857](#1857)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Add support of auto suggestion memory variable ([#1819](#1819)) ([@cosmicshuai](https://github.com/cosmicshuai)) - fix: Fixed Multiple Choice Type undo/redo functionality ([#1844](#1844)) ([@tdurnford](https://github.com/tdurnford)) - fix: RepeatDialog not shown ([#1835](#1835)) ([@yeze322](https://github.com/yeze322)) - fix: do not preset name when creating a dialog ([#1805](#1805)) ([@liweitian](https://github.com/liweitian)) - fix: luis authoringRegion not update in popup form ([#1818](#1818)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Check all expressions in dialog ([#1798](#1798)) ([@lei9444](https://github.com/lei9444)) - fix: TextWidget hover ([#1825](#1825)) ([@tdurnford](https://github.com/tdurnford)) - fix: Create bot from scratch may create a non-empty bot ([#1796](#1796)) ([@liweitian](https://github.com/liweitian)) - fix: Updated release version on about page ([#1788](#1788)) ([@tdurnford](https://github.com/tdurnford)) - fix: Remove the unused lufiles in notifications ([#1760](#1760)) ([@lei9444](https://github.com/lei9444)) - fix: update form correctly when undo or redo changes ([#1808](#1808)) ([@lei9444](https://github.com/lei9444)) - fix: handle multiple ctrl+z in lg editor ([#1804](#1804)) ([@zhixzhan](https://github.com/zhixzhan)) #### Changed - refactor: re-provide `getLgTemplates` api ([#1746](#1746)) ([@yeze322](https://github.com/yeze322)) - style: updated delete icon ([#1892](#1892)) ([@tdurnford](https://github.com/tdurnford)) - refactor: let ElementWrapper control the focus state ([#1880](#1880)) ([@yeze322](https://github.com/yeze322)) - refactor: render Elements with composition strategy (ElementRenderer -> ElementWrapper) ([#1873](#1873)) ([@yeze322](https://github.com/yeze322)) #### Other - chore: migrate IfCondition, SwitchCondition, Foreach(Page) to uischema ([#1899](#1899)) ([@yeze322](https://github.com/yeze322)) - chore: migrate TextInput and all other \*Input types to uischema ([#1874](#1874)) ([@yeze322](https://github.com/yeze322)) - chore: migrate SendActivity, BeginDialog, ReplaceDialog to uischema ([#1840](#1840)) ([@yeze322](https://github.com/yeze322)) - chore: retire 'DefaultRenderer' in visual editor ([#1836](#1836)) ([@yeze322](https://github.com/yeze322)) - chore: update lu/lg all up view ([#1806](#1806)) ([@liweitian](https://github.com/liweitian)) - chore: share server's resource to lsp server ([#1793](#1793)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: refactor lg page route & url ([#1756](#1756)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: convert ludown to bf-lu ([#1608](#1608)) ([@lei9444](https://github.com/lei9444)) - chore: proxy lsp ws request in dev ([#1754](#1754)) ([@zhixzhan](https://github.com/zhixzhan)) - docs: fix a typo ([#1901](#1901)) ([@HiltonGiesenow](https://github.com/HiltonGiesenow)) - docs: use correct link in events and triggers documentation ([#1832](#1832)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix memory documentation link and typo ([#1833](#1833)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix the links to intents and advanced definitions ([#1854](#1854)) ([@arafattehsin](https://github.com/arafattehsin)) - chore: bump immer to 5.2.0 ([#1846](#1846)) ([@cwhitten](https://github.com/cwhitten)) - chore: update botproject packages ([#1809](#1809)) ([@luhan2017](https://github.com/luhan2017)) - chore: update github templates ([@a-b-r-o-w-n](https://github.com/a-b-r-o-w-n)) - chore: update schema and samples ([@luhan2017](https://github.com/luhan2017))

liweitian requested review from a-b-r-o-w-n, boydc2014 and cwhitten as code owners December 23, 2019 08:22

liweitian changed the title ~~fix: create bot from scratch may create a non-empty bot~~ Fix: create bot from scratch may create a non-empty bot Dec 23, 2019

liweitian changed the title ~~Fix: create bot from scratch may create a non-empty bot~~ fix: Create bot from scratch may create a non-empty bot Dec 25, 2019

boydc2014 requested changes Dec 27, 2019

View reviewed changes

liweitian and others added 3 commits December 30, 2019 14:09

fix bug

a042e65

handle comments

e174bc3

handle comments

955d4a0

liweitian force-pushed the liweitian/fixbug branch from 24a7895 to 955d4a0 Compare December 30, 2019 06:09

boydc2014 approved these changes Dec 30, 2019

View reviewed changes

boydc2014 merged commit dc935a6 into master Dec 30, 2019

boydc2014 deleted the liweitian/fixbug branch December 30, 2019 10:41

a-b-r-o-w-n mentioned this pull request Jan 27, 2020

release: 01-27-2020 #1910

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Create bot from scratch may create a non-empty bot #1796

fix: Create bot from scratch may create a non-empty bot #1796

liweitian commented Dec 23, 2019 •

edited

Loading

github-actions bot commented Dec 23, 2019

boydc2014 Dec 27, 2019

boydc2014 Dec 27, 2019

fix: Create bot from scratch may create a non-empty bot #1796

fix: Create bot from scratch may create a non-empty bot #1796

Conversation

liweitian commented Dec 23, 2019 • edited Loading

Description

Task Item

Type of change

Checklist

Screenshots

github-actions bot commented Dec 23, 2019

boydc2014 Dec 27, 2019

Choose a reason for hiding this comment

boydc2014 Dec 27, 2019

Choose a reason for hiding this comment

liweitian commented Dec 23, 2019 •

edited

Loading