chore: update lu/lg all up view #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liweitian
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
|
@zhixzhan can you help review this first? |
zhixzhan
previously requested changes
Dec 27, 2019
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-understanding/index.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-understanding/styles.js
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/language-understanding/styles.js
Outdated
Show resolved
Hide resolved
zhixzhan
reviewed
Dec 27, 2019
|
To keep |
|
|
liweitian
force-pushed
the
liweitian/updateAllupView
branch
2 times, most recently
from
1dc5a18
to
74c0771
Compare
yeze322
reviewed
Jan 7, 2020
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Jan 7, 2020
Composer/packages/client/src/pages/language-generation/index.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Jan 7, 2020
yeze322
reviewed
Jan 7, 2020
Composer/packages/client/src/pages/language-understanding/index.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Jan 7, 2020
yeze322
reviewed
Jan 7, 2020
Composer/packages/client/src/pages/language-understanding/index.tsx
Outdated
Show resolved
Hide resolved
|
@liweitian Left some comments on code quality, we can make small improvements (sorry I clicked on the 'closed' button) |
Thanks @yeze322 , I think @zhixzhan should also take a look for those comments and advises, see if we can optimize some internal structure in this PR. If some points is valid but requires a bigger change, it's OK to mark an issue and solve it in next batch. |
liweitian
force-pushed
the
liweitian/updateAllupView
branch
from
74c0771
to
9d3a56b
Compare
boydc2014
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Looks good to me after several rounds of review, let's wait till @cwhitten and @a-b-r-o-w-n has a chance to look at.
Merged
cwhitten
added a commit
that referenced
this pull request
Jan 28, 2020
### 01-27-2020 #### Added - feat: enrich prebuilt memory paths and add user defined memory paths ([#1868](#1868)) ([@lei9444](https://github.com/lei9444)) - feat: Language-Understanding LSP ([#1711](#1711)) ([@cosmicshuai](https://github.com/cosmicshuai)) - feat: lu shell api ([#1810](#1810)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: Start Botproject runtime in bot folder ([#1672](#1672)) ([@VanyLaw](https://github.com/VanyLaw)) - feat: Schema-driven visual editor - migrates 15 simple types ([#1811](#1811)) ([@yeze322](https://github.com/yeze322)) - feat: Update OnConversationUpdate actions ([#1794](#1794)) ([@luhan2017](https://github.com/luhan2017)) - feat: Update LG and built in expression functions in LSP ([#1790](#1790)) ([@Danieladu](https://github.com/Danieladu)) - feat: Add dynamic choices to Choice Prompt ([#1777](#1777)) ([@tdurnford](https://github.com/tdurnford)) - feat: update ui for new schema ([#1775](#1775)) ([@alanlong9278](https://github.com/alanlong9278)) - feat: lu all up view ux enhancement ([#1879](#1879)) ([@zhixzhan](https://github.com/zhixzhan)) - feat: add autoClosingPairs for lg editor ([#1789](#1789)) ([@cosmicshuai](https://github.com/cosmicshuai)) #### Fixed - fix: update the lg content to store when editor editing ([#1884](#1884)) ([@lei9444](https://github.com/lei9444)) - fix: Aligned elements in prompt settings ([#1893](#1893)) ([@tdurnford](https://github.com/tdurnford)) - fix: remove label from validations ([#1891](#1891)) ([@tdurnford](https://github.com/tdurnford)) - fix: Undo / redo behavior on LG resources ([#1813](#1813)) ([@lei9444](https://github.com/lei9444)) - fix: botproject build script powershell version limit ([#1857](#1857)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Add support of auto suggestion memory variable ([#1819](#1819)) ([@cosmicshuai](https://github.com/cosmicshuai)) - fix: Fixed Multiple Choice Type undo/redo functionality ([#1844](#1844)) ([@tdurnford](https://github.com/tdurnford)) - fix: RepeatDialog not shown ([#1835](#1835)) ([@yeze322](https://github.com/yeze322)) - fix: do not preset name when creating a dialog ([#1805](#1805)) ([@liweitian](https://github.com/liweitian)) - fix: luis authoringRegion not update in popup form ([#1818](#1818)) ([@VanyLaw](https://github.com/VanyLaw)) - fix: Check all expressions in dialog ([#1798](#1798)) ([@lei9444](https://github.com/lei9444)) - fix: TextWidget hover ([#1825](#1825)) ([@tdurnford](https://github.com/tdurnford)) - fix: Create bot from scratch may create a non-empty bot ([#1796](#1796)) ([@liweitian](https://github.com/liweitian)) - fix: Updated release version on about page ([#1788](#1788)) ([@tdurnford](https://github.com/tdurnford)) - fix: Remove the unused lufiles in notifications ([#1760](#1760)) ([@lei9444](https://github.com/lei9444)) - fix: update form correctly when undo or redo changes ([#1808](#1808)) ([@lei9444](https://github.com/lei9444)) - fix: handle multiple ctrl+z in lg editor ([#1804](#1804)) ([@zhixzhan](https://github.com/zhixzhan)) #### Changed - refactor: re-provide `getLgTemplates` api ([#1746](#1746)) ([@yeze322](https://github.com/yeze322)) - style: updated delete icon ([#1892](#1892)) ([@tdurnford](https://github.com/tdurnford)) - refactor: let ElementWrapper control the focus state ([#1880](#1880)) ([@yeze322](https://github.com/yeze322)) - refactor: render Elements with composition strategy (ElementRenderer -> ElementWrapper) ([#1873](#1873)) ([@yeze322](https://github.com/yeze322)) #### Other - chore: migrate IfCondition, SwitchCondition, Foreach(Page) to uischema ([#1899](#1899)) ([@yeze322](https://github.com/yeze322)) - chore: migrate TextInput and all other \*Input types to uischema ([#1874](#1874)) ([@yeze322](https://github.com/yeze322)) - chore: migrate SendActivity, BeginDialog, ReplaceDialog to uischema ([#1840](#1840)) ([@yeze322](https://github.com/yeze322)) - chore: retire 'DefaultRenderer' in visual editor ([#1836](#1836)) ([@yeze322](https://github.com/yeze322)) - chore: update lu/lg all up view ([#1806](#1806)) ([@liweitian](https://github.com/liweitian)) - chore: share server's resource to lsp server ([#1793](#1793)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: refactor lg page route & url ([#1756](#1756)) ([@zhixzhan](https://github.com/zhixzhan)) - chore: convert ludown to bf-lu ([#1608](#1608)) ([@lei9444](https://github.com/lei9444)) - chore: proxy lsp ws request in dev ([#1754](#1754)) ([@zhixzhan](https://github.com/zhixzhan)) - docs: fix a typo ([#1901](#1901)) ([@HiltonGiesenow](https://github.com/HiltonGiesenow)) - docs: use correct link in events and triggers documentation ([#1832](#1832)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix memory documentation link and typo ([#1833](#1833)) ([@arafattehsin](https://github.com/arafattehsin)) - docs: fix the links to intents and advanced definitions ([#1854](#1854)) ([@arafattehsin](https://github.com/arafattehsin)) - chore: bump immer to 5.2.0 ([#1846](#1846)) ([@cwhitten](https://github.com/cwhitten)) - chore: update botproject packages ([#1809](#1809)) ([@luhan2017](https://github.com/luhan2017)) - chore: update github templates ([@a-b-r-o-w-n](https://github.com/a-b-r-o-w-n)) - chore: update schema and samples ([@luhan2017](https://github.com/luhan2017))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update lu/lg all up view UX
Task Item
Closes #822
Type of change
Please delete options that are not relevant.
Checklist
Screenshots