Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAS1.4.3] [Visual Requirements-Create a new bot configuration] Luminosity Ratio is less than 4.5:1 for “Hide, Copy, Error message” controls #1743

Closed
Kumar2608 opened this issue Aug 19, 2019 · 4 comments

Comments

@Kumar2608
Copy link

Kumar2608 commented Aug 19, 2019

Actual Result:
Luminosity Ratio is less than 4.5:1 for “Hide, Copy, Error message” controls and Learn more links

Expected Result:
Luminosity Ratio should be greater than or equal to 4.5:1 for “Hide, Copy, Error message” controls and Learn more links

Note: Same issue repro for below path
Resources->Transcripts and chat files->choose a different location.
Luminosity ration is less than 4.5:1 for Browse control
Please refer the attachment:MAS1 4 3_Choose different location

Repro Steps:
1.Open the Bot Framework V4 Emulator.
2.Welcome tab screen gets opened
3.Navigate to the Create a new bot configuration and select it
4.Dialog gest opened
5.Navigate to the “Hide, Copy, Error message” controls and Learn more links
6.Open 'Colour Contrast Analyser' application.
7. Verify whether Luminosity Ratio is less than 4.5:1 for “Hide, Copy, Error message” controls and Learn more links

User Impact:
Users with low vision or colour blindness needs that difference between contrast of link is always high.

Test Environment:
OS Build: Version 1903(OS Build 18362.239)
Browser: Edge
Application: Bot Framework V4 Emulator
Tool: Colour contrast analyser

MAS Reference Link:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a73546c7-765f-489c-b18f-afb659fe99e6}
MAS1 4 3_Create new bot configuration
MAS1 4 3_Choose different location

@corinagum
Copy link
Contributor

corinagum commented Aug 28, 2019

Looping @DesignPolice in - I have fixed the anchor color, but I wanted to check with you on the yellow text. (I also sent this message on Teams, if you need more context.

Currently, the text color is #B89500 on #f4f4f4 background, but the contrast ratio isn't high enough.

image

Note, anchor text is fixed in PR #1787

@corinagum
Copy link
Contributor

@DesignPolice offline conversation introduced the possibility of changing the text to grey, and adding a warning icon to indicate type of message.

@corinagum corinagum added the 4.6 label Sep 3, 2019
corinagum added a commit that referenced this issue Sep 4, 2019
tonyanziano pushed a commit that referenced this issue Sep 4, 2019
* #1743 - Fix endpiont notify text color

* Update CHANGELOG.md

* Fix endpoint warning color via themes

* Apply PR Feedback
@Kumar2608
Copy link
Author

Verified in latest bot emulator Version 4.5.2-78641 and issue has partially fixed .Hence reactivating the bug
Luminosity Ratio for Learn more and Hide and copy controls is less than 4.5:1
Please refer the attachment:1743.png
1743

@Kumar2608
Copy link
Author

Verified in latest bot emulator Version 4.5.2-79874 and issue got fixed .Hence we are clsoing this bug.
Now Luminosity Ratio for Learn more ,Hide and copy controls >=4.5:1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants