Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconfiguration to basicperf #5507

Merged
merged 12 commits into from
Aug 8, 2023

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Aug 7, 2023

Add a --add-new-node-before-primary-stops <hostname> that can be combined with --stop-primary-after-s <duration>, which configures in a new node after stopping, and retiring the primary.

@achamayou achamayou marked this pull request as ready for review August 7, 2023 08:30
@achamayou achamayou requested a review from a team as a code owner August 7, 2023 08:30
@ccf-bot
Copy link
Collaborator

ccf-bot commented Aug 7, 2023

add_reconfig_to_basicperf@74027 aka 20230808.13 vs main ewma over 19 builds from 73711 to 74021

Click to see table

main

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ ls_jwt_virtual_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_jwt_virtual_cft^ pi_ls_sgx_cft^ pi_ls_sgx_cft_mem ls_js_virtual_cft^ ls_full_js_virtual_cft^ pi_basic_sgx_cft^ pi_basic_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_jwt_virtual_cft^ pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem pi_basic_mt_virtual_cft^ hist_sgx_cft^ ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_js_virtual_cft^ pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem
73711 20230801.6 0.811372 43668.1 45871.6 58343.1 12491.8 19826.9 1.88908e+07 13157.9 20080.3 1.05021e+07 4341.96 3492.46 22675.7 1.25993e+07 6678.31 1.67936e+07 3293.78 6578.9 6.30784e+06 1748.12 1.05021e+07 34873.6 2.51822e+07 69942.3 47468.1 1427.2 1.05021e+07 1428.99 1.05021e+07 830785 1.18094e+06 8.1481e+06 3.07609e+07 nan nan nan
73720 20230801.9 0.776609 43842.2 47169.8 57870.4 11269.7 19897.7 1.88908e+07 12987 20000 1.05021e+07 4453.19 3486.58 22604 1.25993e+07 6746.8 1.67936e+07 3256.29 6666.7 6.30784e+06 1744.24 1.05021e+07 34743.3 2.51822e+07 65423.6 43327.3 1436.93 1.05021e+07 1424.64 1.05021e+07 823385 1.18131e+06 8.17281e+06 3.07729e+07 nan nan nan
73734 20230801.14 0.812897 45721.1 50273.2 55080.9 12362 19965 1.88908e+07 12983.3 20133.8 1.05021e+07 4541.17 3465.49 22758.9 1.25993e+07 6339.77 1.67936e+07 3308.33 6644.5 6.30784e+06 1741.68 1.05021e+07 35728.9 2.51822e+07 62432.8 42491 1436.76 1.05021e+07 1425.69 1.05021e+07 834723 1.18456e+06 8.15449e+06 3.08476e+07 nan nan nan
73745 20230801.18 0.790283 45486.7 47459.5 58615.3 12475.9 19972.8 1.88908e+07 12740.3 20042.2 1.05021e+07 4468.63 3544.11 22723.7 1.25993e+07 6680.54 1.67936e+07 3290.04 6173.8 6.30784e+06 1743.88 1.05021e+07 35368.8 2.51822e+07 73698.5 48480.8 1431.08 1.05021e+07 1429.18 1.05021e+07 838542 1.18022e+06 8.14615e+06 3.08713e+07 4615.6 1748.8 8.40499e+06
73777 20230802.4 0.768526 45650.2 49459.7 59718.2 12475.4 19974.6 1.88908e+07 12926.7 20134 1.05021e+07 4458.58 3575.58 22745.7 1.25993e+07 6713.41 1.67936e+07 3284.09 6595.7 6.30784e+06 1744 1.05021e+07 36072.1 2.30851e+07 70649.9 43652.4 1437.85 1.05021e+07 1430.69 1.05021e+07 828420 1.17762e+06 8.13567e+06 3.10068e+07 4625.2 1748.2 8.40499e+06
73794 20230802.11 0.788545 45820.2 49614.7 57118.1 12272.1 20061.5 1.88908e+07 12965.6 20114.6 1.05021e+07 4489.18 3549.16 22119 1.46964e+07 6360.75 1.67936e+07 3302.1 6653.2 6.30784e+06 1740.89 1.05021e+07 34513.7 2.93765e+07 54864.6 50154.3 1423.44 1.05021e+07 1426.62 1.05021e+07 829086 1.18336e+06 8.17539e+06 3.08434e+07 4516.6 1714.8 1.25993e+07
73801 20230802.13 0.782836 45831.3 49515.5 56374.6 12362 20064.3 1.88908e+07 13037.1 20060.1 1.05021e+07 4408.51 3558.21 22220.1 1.46964e+07 6405.25 1.67936e+07 3276.33 6531.2 6.30784e+06 1758.14 1.05021e+07 35020 2.93765e+07 60729.3 46647.2 1438.79 1.05021e+07 1433.93 1.05021e+07 838844 1.18438e+06 8.15654e+06 3.07019e+07 4496.4 1723.6 1.25993e+07
73815 20230802.17 0.79794 45676.9 50307.6 56414.7 12384.1 19896.7 1.88908e+07 13247 19669.9 1.05021e+07 4463.75 3522.27 21987.3 1.46964e+07 6352.19 1.67936e+07 3264.72 6611.5 6.30784e+06 1741.79 1.05021e+07 34856.8 2.93765e+07 65856.4 50788.5 1423.52 1.05021e+07 1425.12 1.05021e+07 828193 1.17909e+06 8.17271e+06 3.21028e+07 4513.9 1720.4 1.25993e+07
73824 20230802.20 0.7785 43601.8 48289.8 55191.4 12274.3 19932.6 1.88908e+07 13203.9 19936.6 1.05021e+07 4477.96 3479.34 21729.5 1.46964e+07 6310.38 1.67936e+07 3275.41 6422.6 6.30784e+06 1733.84 1.05021e+07 34827.5 3.14737e+07 57879.8 42443.7 1418.02 1.05021e+07 1403.56 1.05021e+07 832460 1.18064e+06 8.15329e+06 3.09165e+07 4491.2 1704.9 1.25993e+07
73833 20230803.1 0.767432 44054.3 48003.5 55051.9 12290.9 19895.7 1.88908e+07 12933.8 20037.1 1.05021e+07 4448.1 3480.84 22029.9 1.46964e+07 6344.16 1.67936e+07 3387.2 6509.4 6.30784e+06 1739.61 1.05021e+07 34368.6 2.93765e+07 54270 46396 1434.2 1.05021e+07 1425.8 1.05021e+07 830551 1.18078e+06 8.16841e+06 3.06987e+07 4552.3 1712.4 1.25993e+07
73844 20230803.7 0.78827 43645.5 47228.6 48176.8 12866.8 19982.3 1.67936e+07 12950.2 20054.3 1.05021e+07 4434.39 3489.54 22226.4 1.46964e+07 6684.56 1.67936e+07 3252.94 6471.4 6.30784e+06 1740.9 1.05021e+07 34977.9 2.93765e+07 69882.2 45790.4 1431.06 1.05021e+07 1416.79 1.05021e+07 829927 1.17775e+06 8.15355e+06 3.08629e+07 4433.2 1722.5 1.25993e+07
73857 20230803.12 0.808633 43636.1 47165.4 54191.6 12452.3 19988.7 1.88908e+07 13090.4 20057.8 1.05021e+07 4442.91 3471.35 22275 1.46964e+07 6721.4 1.67936e+07 3264.04 6622 6.30784e+06 1745.82 1.05021e+07 34818.9 2.93765e+07 63751.2 49838.7 1438.49 1.05021e+07 1431.17 1.05021e+07 832243 1.17951e+06 8.17294e+06 3.0848e+07 4490.2 1733 1.25993e+07
73868 20230803.16 0.767168 46069.3 42909.1 55223.9 12324 19972.5 1.88908e+07 12946 20066.7 1.05021e+07 4419.54 3490.07 22104.3 1.46964e+07 6719.59 1.67936e+07 3270.05 6474.7 6.30784e+06 1738.6 1.05021e+07 34448.2 2.93765e+07 52677.1 45949.3 1414.21 1.05021e+07 1418.57 1.05021e+07 839690 1.17769e+06 8.15316e+06 3.08424e+07 4511.7 1714 1.25993e+07
73883 20230803.21 0.826996 43840 47764.4 55231.5 12297.1 19952.7 1.67936e+07 13018 20003 1.05021e+07 4453.54 3476.76 22083.8 1.46964e+07 6349.36 1.67936e+07 3239.58 6567.7 6.30784e+06 1740.99 1.05021e+07 34890.4 2.93765e+07 67845.9 48176.7 1432.52 1.05021e+07 1425.47 1.05021e+07 828851 1.17836e+06 8.17366e+06 3.06183e+07 4540.4 1721.8 1.25993e+07
73892 20230803.24 0.802924 43948.7 47878 54015.7 12562.4 20074.3 1.88908e+07 13205.3 20138.1 1.25993e+07 4449.44 3483.29 22306.6 1.67936e+07 6368.94 1.67936e+07 3262.22 6550.5 6.30784e+06 1740.73 1.05021e+07 34769.4 2.93765e+07 69799.4 48657.6 1420.98 1.05021e+07 1430.83 1.05021e+07 831510 1.17993e+06 8.14888e+06 3.1209e+07 4552 1728.6 1.25993e+07
73900 20230803.26 0.761475 45747.9 47879 54591.3 12539.3 19968.8 1.88908e+07 13050.1 20210.4 1.25993e+07 4460.49 3549.61 22370.7 1.67936e+07 6375.42 1.67936e+07 3369.08 6574.4 6.30784e+06 1740.58 1.05021e+07 34835.1 2.93765e+07 62961.5 50311.8 1436.48 1.05021e+07 1427.37 1.05021e+07 802461 1.17535e+06 8.15193e+06 3.2663e+07 4452.6 1717.9 1.25993e+07
73938 20230804.13 0.794691 45536.3 47977.5 53871.1 12812.8 19979.8 1.88908e+07 12907.7 20095.9 1.25993e+07 4482.1 3568.79 22273 1.67936e+07 6368.55 1.67936e+07 3288.24 6664.7 6.30784e+06 1744.42 1.05021e+07 34533.2 2.93765e+07 64405.2 48176.6 1434.54 1.05021e+07 1430.22 1.05021e+07 837139 1.17642e+06 8.14956e+06 3.09338e+07 4520.8 1728.8 1.25993e+07
73955 20230807.6 0.801307 43934.3 48026.8 54527.6 12421.1 20091 1.88908e+07 13186.7 20209 1.25993e+07 4423.14 3572.61 22457 1.67936e+07 6721.54 1.67936e+07 3245.74 6526.9 6.30784e+06 1742.64 1.05021e+07 34825.7 2.93765e+07 52415.6 48325.6 1434.78 1.05021e+07 1430.76 1.05021e+07 834230 1.17948e+06 8.15618e+06 3.1666e+07 4516.7 1720.9 1.25993e+07
74021 20230808.12 0.806516 43681.8 48001 54088.3 12857.1 19886.6 1.88908e+07 13210.9 20156.5 1.25993e+07 4461.7 3405.82 22130.3 1.67936e+07 6369.53 1.67936e+07 3258.26 6461.2 6.30784e+06 1740.76 1.05021e+07 34496.1 2.93765e+07 76483.6 48007.7 1426.71 1.05021e+07 1426.32 1.05021e+07 836568 1.17363e+06 8.17483e+06 3.079e+07 4509 1721.8 1.25993e+07

add_reconfig_to_basicperf

build_id build_number Commit latency factor ls_virtual_cft^ pi_ls_virtual_cft^ pi_basic_virtual_cft^ pi_basic_js_virtual_cft^ ls_jwt_virtual_cft^ pi_ls_jwt_virtual_cft^ pi_basic_mt_virtual_cft^ ls_js_virtual_cft^ ls_full_js_virtual_cft^ ls_js_jwt_virtual_cft^ hist_sgx_cft^ ls_sgx_cft^ ls_sgx_cft_mem pi_ls_sgx_cft^ pi_ls_sgx_cft_mem pi_basic_sgx_cft^ pi_basic_sgx_cft_mem pi_basic_js_sgx_cft^ pi_basic_js_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem pi_ls_jwt_sgx_cft^ pi_ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem RB put (/s)^ CHAMP put (/s)^ RB get (/s)^ CHAMP get (/s)^ pi_basic_mt_sgx_cft^ pi_basic_mt_sgx_cft_mem
74027 20230808.13 0.811433 45747.8 47683.1 54034.8 4552.5 12302.7 13243.6 69625.9 4437.76 3562.06 3235.23 46326.9 19842.6 1.88908e+07 20113 1.25993e+07 22045 1.67936e+07 1693.9 1.25993e+07 6290.69 1.67936e+07 6487.4 6.30784e+06 1722.4 1.05021e+07 1426.71 1.05021e+07 1434.53 1.05021e+07 830435 1.17552e+06 8.1504e+06 3.07674e+07 34395.5 3.14737e+07

images

tests/infra/basicperf.py Outdated Show resolved Hide resolved
@achamayou achamayou enabled auto-merge (squash) August 7, 2023 15:50
@achamayou achamayou merged commit abeeed6 into microsoft:main Aug 8, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants