-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reconfiguration to basicperf #5507
Merged
achamayou
merged 12 commits into
microsoft:main
from
achamayou:add_reconfig_to_basicperf
Aug 8, 2023
Merged
Add reconfiguration to basicperf #5507
achamayou
merged 12 commits into
microsoft:main
from
achamayou:add_reconfig_to_basicperf
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_reconfig_to_basicperf@74027 aka 20230808.13 vs main ewma over 19 builds from 73711 to 74021 Click to see tablemain
add_reconfig_to_basicperf
|
jumaffre
reviewed
Aug 7, 2023
jumaffre
approved these changes
Aug 7, 2023
eddyashton
reviewed
Aug 7, 2023
eddyashton
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--add-new-node-before-primary-stops <hostname>
that can be combined with--stop-primary-after-s <duration>
, which configures in a new node after stopping, and retiring the primary.