tools: Don't only require FFAPI reviews for report changes in specific directories #22278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
jatgarg
approved these changes
Aug 21, 2024
Comment on lines
+55
to
+58
| /**/api-report/*.api.md @microsoft/fluid-cr-api | ||
| /build-tools/**/api-report/*.api.md @microsoft/fluid-cr-infra | ||
| /server/**/api-report/*.api.md @microsoft/fluid-cr-server | ||
| /tools/**/api-report/*.api.md # Do not require API review for tools packages |
There was a problem hiding this comment.
@Josmithr we shouldn't add ownership to groups unless they explicitly opt into it, so adding cr-infra, and cr-server shouldn't be done unless those groups know and agree to the requirements they are signing up for, to review all changes. it might be a better change to just limit cr-api to the packages directory, rather than creating new layers of ownership
There was a problem hiding this comment.
i would expect some members of those teams to sign off here, to signify that they know and agree to the requirements.
There was a problem hiding this comment.
Fair. I can put up a PR to revert those changes.
Josmithr
added a commit
that referenced
this pull request
Aug 22, 2024
Reverts additions made in #22278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require API reviews for API report changes in
/toolspackages. Also simplify specification patterns for CODEOWNERS, and...fluid-cr-infrareview for API changes in/build-toolspackagesfluid-cr-serverreview for API changes in/serverpackages