Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Don't only require FFAPI reviews for report changes in specific directories #22278

Merged
merged 7 commits into from
Aug 21, 2024
Merged

tools: Don't only require FFAPI reviews for report changes in specific directories #22278

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dabdffd
tools: Don't only require FFAPI reviews for report changes in specifi…
Josmithr Aug 20, 2024
9941d8d
test: Remove reviewer
Josmithr Aug 20, 2024
6d82c6d
Revert "test: Remove reviewer"
Josmithr Aug 20, 2024
eb674f3
tools: Update codeowners
Josmithr Aug 21, 2024
56ad22c
fix: Issues
Josmithr Aug 21, 2024
820c1ed
remove: Invalid entry
Josmithr Aug 21, 2024
ecda9bc
tools: Add a server requirement for server API reports
Josmithr Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@
# Fluid Devtools source
/packages/tools/devtools/**/src @microsoft/fluid-cr-devtools

# Non-internal API changes
/**/api-report/*.public.api.md @microsoft/fluid-cr-api
/**/api-report/*.beta.api.md @microsoft/fluid-cr-api
/**/api-report/*.alpha.api.md @microsoft/fluid-cr-api
# API report changes
# TODO: if we ever add `.internal` API reports, we will want to omit them here
/**/api-report/*.api.md @microsoft/fluid-cr-api
/build-tools/**/api-report/*.api.md @microsoft/fluid-cr-infra
/server/**/api-report/*.api.md @microsoft/fluid-cr-server
/tools/**/api-report/*.api.md # Do not require API review for tools packages
Comment on lines +55 to +58
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josmithr we shouldn't add ownership to groups unless they explicitly opt into it, so adding cr-infra, and cr-server shouldn't be done unless those groups know and agree to the requirements they are signing up for, to review all changes. it might be a better change to just limit cr-api to the packages directory, rather than creating new layers of ownership

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would expect some members of those teams to sign off here, to signify that they know and agree to the requirements.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I can put up a PR to revert those changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#22294


# Changesets and release notes
/**/.changeset/*.md @microsoft/fluid-cr-docs
Expand Down
Loading