Microsoft.Build.Traversal: propogate well known global properties (#208)

Fixes #207
microsoft · Oct 7, 2020 · d1a4c68 · d1a4c68
1 parent 5912581
commit d1a4c68
Show file tree

Hide file tree

Showing 3 changed files with 69 additions and 1 deletion.
diff --git a/src/Traversal.UnitTests/TraversalTests.cs b/src/Traversal.UnitTests/TraversalTests.cs
@@ -277,6 +277,73 @@ public void TraversalGlobalPropertiesPreserveAdditionalProperties(string additio
             item.GetMetadataValue("AdditionalProperties").ShouldBe(expected);
         }
 
+        [Theory]
+        [InlineData("Platform=x86", "x86", null, null, null, null)]
+        [InlineData(null, null, "Configuration=Debug", "Debug", null, null)]
+        [InlineData(null, null, null, null, "TargetFramework=net472", "net472")]
+        [InlineData("Platform=x64", "x64", "Configuration=Debug", "Debug", null, null)]
+        public void TraversalPreserveWellKnownProperties(string setPlatformMetadata, string expectedPlatform, string setConfigurationMetadata, string expectedConfiguration, string setTargetFrameworkMetadata, string expectedTargetFramework)
+        {
+            // Create a project that prints out its Platform, Configuration, and TargetFramework in the Build target.
+            string csProj = GetSkeletonCSProjWithMessageTasksPrintingWellKnownMetadata("A").FullPath;
+
+            // Create a traversal project that invokes the csproj.
+            ProjectCreator subTraversalProject = ProjectCreator
+                .Templates
+                .TraversalProject(
+                    path: GetTempFile("dirs.proj"),
+                    customAction: creator =>
+                    {
+                        var metadata = new Dictionary<string, string>();
+                        if (setPlatformMetadata != null)
+                        {
+                            metadata["SetPlatform"] = setPlatformMetadata;
+                        }
+
+                        if (setConfigurationMetadata != null)
+                        {
+                            metadata["SetConfiguration"] = setConfigurationMetadata;
+                        }
+
+                        if (setTargetFrameworkMetadata != null)
+                        {
+                            metadata["SetTargetFramework"] = setTargetFrameworkMetadata;
+                        }
+
+                        creator.ItemProjectReference(csProj, metadata: metadata);
+                    })
+                .Save()
+                .TryBuild("Build", out bool result, out BuildOutput buildOutput);
+
+            ProjectCreator GetSkeletonCSProjWithMessageTasksPrintingWellKnownMetadata(string projectName)
+            {
+                return ProjectCreator.Templates.SdkCsproj(path: GetTempFile($"{projectName}.csproj"), sdk: string.Empty)
+                    .Target("Build")
+                    .TaskMessage("Platform: $(Platform)")
+                    .TaskMessage("Configuration: $(Configuration)")
+                    .TaskMessage("TargetFramework: $(TargetFramework)")
+                    .Save();
+            }
+
+            // Verify we received three normal messages and that the csproj received the right properties from the traversal project.
+            buildOutput.Messages.Normal.Count().ShouldBe(3);
+
+            if (setPlatformMetadata != null)
+            {
+                buildOutput.Messages.Normal.ShouldContain($"Platform: {expectedPlatform}");
+            }
+
+            if (setConfigurationMetadata != null)
+            {
+                buildOutput.Messages.Normal.ShouldContain($"Configuration: {expectedConfiguration}");
+            }
+
+            if (setTargetFrameworkMetadata != null)
+            {
+                buildOutput.Messages.Normal.ShouldContain($"TargetFramework: {expectedTargetFramework}");
+            }
+        }
+
         [Theory]
         [InlineData("Build")]
         [InlineData("Clean")]

diff --git a/src/Traversal/Sdk/Sdk.targets b/src/Traversal/Sdk/Sdk.targets
@@ -127,6 +127,7 @@
     <MSBuild Projects="@(ProjectReference)"
              Condition="'%(ProjectReference.Build)' != 'false'"
              BuildInParallel="$([MSBuild]::ValueOrDefault('%(ProjectReference.BuildInParallel)', '$(BuildInParallel)'))"
+             Properties="%(ProjectReference.SetConfiguration); %(ProjectReference.SetPlatform); %(ProjectReference.SetTargetFramework)"
              SkipNonexistentProjects="$(SkipNonexistentProjects)"
              SkipNonexistentTargets="$(SkipNonexistentTargets)"
              StopOnFirstFailure="$(StopOnFirstFailure)"

diff --git a/src/Traversal/version.json b/src/Traversal/version.json
@@ -1,4 +1,4 @@
 {
   "inherit": true,
-  "version": "2.1"
+  "version": "2.2"
 }