Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Build.Traversal: propogate well known global properties #208

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Microsoft.Build.Traversal: propogate well known global properties #208

merged 2 commits into from
Oct 7, 2020

Conversation

forrestcoward
Copy link
Contributor

See issue #207 for discussion on the change.

@forrestcoward
Copy link
Contributor Author

@jeffkl, do I need to update the version in version.json as well?

@jeffkl
Copy link
Contributor

jeffkl commented Oct 7, 2020

do I need to update the version in version.json as well?

Yeah I suppose it changes enough behavior, might as well bump the minor version. Thanks for suggesting that

@jeffkl jeffkl closed this Oct 7, 2020
@jeffkl jeffkl reopened this Oct 7, 2020
jeffkl
jeffkl approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jeffkl jeffkl merged commit d1a4c68 into microsoft:master Oct 7, 2020
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkl jeffkl jeffkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forrestcoward @jeffkl