Update to WorldAnchorManager and added MultiLens capabilities #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Sphere based tagalong to have the option to hide itself after initialization.
…cts on subsequent sessions. Updated Sharing Stage to also have a disconnect event. Replaced AnchorText prefab with AnchorDebug prefab. Updated SharingTest scene.
…r to better facilitate networked anchors across shared experiences.
Added string.IsNullOrEmpty for anchorId when doing anchor ops.
StephenHodgson
commented
Jun 27, 2017
| @@ -205,14 +205,14 @@ public void WaitForAnchor() | |||
| /// Attempts to attach to an anchor by anchorName in the local store.. | |||
| /// </summary> | |||
| /// <returns>True if it attached, false if it could not attach</returns> | |||
| private bool AttachToCachedAnchor(string AnchorName) | |||
| private bool AttachToCachedAnchor(string anchorName) | |||
There was a problem hiding this comment.
@darax it would be nice to make the UNetAnchorManager inherit from the WorldAnchorManager, but I wasn't sure where to start. I noticed this class inherits from NetworkBehavior.
Closed
StephenHodgson
changed the title
…exporting/uploading. Reverted Export anchor logic, removed check if anchor was set already. Should overwrite whatever is there.
…rns the current room instance, before attaching anchor.
Made the update loop wait until the sharing service is ready and in a room before processing anchor ops. Added a room listener for anchors changed to initiate a new download. Updated download logic to return the download request response. Updated Anchor_OnTrackingChanged callback to not export the anchor again, when located and to properly re attempt to anchor again if unable to loacte anchor.
Fixed issue with first run check.
Updated AutoJoinSessionAndRoom to properly listen for the SharingSessionTracker discconection event instead of the SharingManagers
StephenHodgson
commented
Aug 5, 2017
| @@ -131,26 +131,28 @@ protected virtual void AnchorStoreReady(WorldAnchorStore anchorStore) | |||
| /// <param name="located">Indicates if the anchor is located or not located.</param> | |||
| private void Anchor_OnTrackingChanged(WorldAnchor anchor, bool located) | |||
| { | |||
| if (located && SaveAnchor(anchor, export: false)) | |||
There was a problem hiding this comment.
I should double check this and make sure this is a desired change.
added 2 commits
August 31, 2017 19:28
# Conflicts: # Assets/HoloToolkit/Input/Scripts/Interactions/TapToPlace.cs
# Conflicts: # Assets/HoloToolkit/BuildAndDeploy/Editor/BuildDeployPortal.cs
added 2 commits
September 8, 2017 16:16
… not have good equality checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorldAnchorManager. Handles creating and deleting Anchors better.SharedWorldAnchorManagerthat inherits fromWorldAnchorManager.SharingTestscene.SharedWorldAnchorcomponent by default.TapToPlace. No longer uses a friendly anchor name, but instead uses theGameObject.nameof the object that is being moved.AutoJoinSessiontoAutoJoinSessionAndRoomand anchors the whole scene appropriately. See improvements for ImportExportAnchorManager #728.SharingStageto handle server disconnections better.ServerSessionsTracker.SphereBasedTagalongto have the option to hide itself after initialization.AnchorText.prefabwithAnchorDebug.prefab.SharingManagerDisconnectedevent toSharingStage.See #493, #178 and #70
Breaking Changes
GameObjectsthat utilize theWorldAnchorStoreneed to have unique names.