Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Launcher] Something is putting focus on the listview items. #2259

Closed
jyuwono opened this issue Apr 20, 2020 · 6 comments
Closed

[Launcher] Something is putting focus on the listview items. #2259

jyuwono opened this issue Apr 20, 2020 · 6 comments
Assignees
@ryanbodrug-microsoft
Labels
Hot Fix Items we will product an out-of-band release for Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@jyuwono
Copy link
Contributor

jyuwono commented Apr 20, 2020 •
edited by ryanbodrug-microsoft
Loading

Something is putting focus on the listview items. Should be easy to fix, but we need to identify a clear repro to say it's fixed.

Repro.

  1. Right Click on a Result Item.
  2. Press Space.

See Screenshot:
Launcher_StealingFocus_FromTexbox
@jyuwono jyuwono added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Apr 20, 2020
@jyuwono jyuwono added this to the Build 2020 milestone Apr 20, 2020
@jyuwono
Copy link
Contributor Author

jyuwono commented Apr 20, 2020

@ryanbodrug-microsoft I don't know the details of the issue you mentioned here. Please add some more background info.

@jyuwono
Copy link
Contributor Author

jyuwono commented Apr 28, 2020

@ryanbodrug-microsoft is this still repro? We need repro steps/guidance

@ryanbodrug-microsoft
Copy link
Contributor

I dont' have repro steps. Somehow the results list gets put into focus. A boarder appears around the listviewitem, and you can no longer type into the textbox. Udit reported seeing this in the bug bash as well.

@crutkas
Copy link
Member

crutkas commented May 15, 2020

This still exists for the mix UWP/WPF mode. We should wait until we do the full WPF flip

@crutkas crutkas modified the milestones: Build 2020, v1.0 Release May 15, 2020
@ryanbodrug-microsoft
Copy link
Contributor

I found a repro. Right-Click and the press spacebar.

This was referenced May 20, 2020
Closed
Closed
Merged
3 tasks
@jyuwono jyuwono mentioned this issue May 20, 2020
Closed
@jyuwono jyuwono added the Status-In progress This issue or work-item is under development label May 20, 2020
@ryanbodrug-microsoft ryanbodrug-microsoft added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 21, 2020
@crutkas crutkas mentioned this issue May 22, 2020
Closed
@jyuwono jyuwono added Hot Fix Items we will product an out-of-band release for and removed Status-In progress This issue or work-item is under development labels May 22, 2020
@jyuwono jyuwono removed this from the v1.0 Release milestone May 22, 2020
@jyuwono jyuwono mentioned this issue May 22, 2020
Closed
@crutkas
Copy link
Member

crutkas commented May 22, 2020

We just released 0.18.1 which will have this fix included in it.

@crutkas crutkas closed this as completed May 22, 2020
@jyuwono jyuwono mentioned this issue May 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanbodrug-microsoft ryanbodrug-microsoft

Labels
Hot Fix Items we will product an out-of-band release for Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crutkas @jyuwono @ryanbodrug-microsoft