Disabling IsRightTapEnabled on all UI Elements that steal focus

[ryanbodrug-microsoft]

Summary of the Pull Request

• This PR disables the IsRightTapEnabled on all UIElements.

References

PR Checklist

• Applies to [Launcher] Something is putting focus on the listview items. #2259
• CLA signed. If not, go over here and sign the CLA
• [] Tests added/passed
• [] Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

1. Where provided in xaml specify IsRightTapEnabled=False
2. Override the listviewitem control template so that IsRightTapEnabled can be set to false on the ListViewItemPresenter
3. On items with no control template such as tool tip and font icon, recurse the visual tree, and set IsRightTapEnabled to false.
4. WHen the context button items are changing then recurse the visual tree and set IsRightTapEnabled. Note this is less efficient than overwritting the template but this is only done on selected or hovered items and there are a small number of elements in the visual tree. Alternatively we could overwrite the GridView and GridView item control templates, but this is quite verbose and error prone, for small perf impact.
   

Validation Steps Performed

• Click on various places around the results window. And observe either of the following are true:

1. There is nothing in the output window. eg. Right Tap was triggered on Right Tap was triggered on Windows.UI.Xaml.Shapes.Rectangle

or

2. Focus remains on the textbox and pressing space doesn't highlight the result. Note: The scrollbar on the right will still trigger the right click event, but doesn't steal focus.

[ryanbodrug-microsoft]

@jyuwono / @crutkas . This is much simpler without the xaml island, and Divyansh has already made the change here. Do we still want to hotfix this or wait until .19?

[dsrivastavv]

LGTM! I wasn't able to hit focus issue on right-click anymore.

[dsrivastavv]

[nit] Is this intended?

[ryanbodrug-microsoft]

Yes. It only writes in debug, and we can use it to identify if something being right clicked is stealing focus. Basically it should rarely print, but it if does (like on the scrollbar), then we can just verify that its not a control that will steal focus.

[dsrivastavv]

Sounds good! Thanks