-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerToy Run: Unexpected priority of search results for "term" #3559
Comments
weird, i don't see this on my comptuer. charmap.exe is the exe so that can't be causing the match as well. |
I noticed this behavior in 18.0, but before I got around to filing a bug report, the update to 18.1 happened (which restarts PowerToys automatically). When I saw that the issue with "term" still occurred, I explicitly shut down PowerToys and started them again. |
Yes this is the same issue. |
@RWeigelt Just realized why i wasn't getting this. I was looking for the native, built in app, not |
@alekhyareddy28 this could be why. Exe name / file description property is "CharacterMap." |
@crutkas, yes I think you are right. I shall look into the exact scores in more detail tomorrow. However, I was wondering if we want to give the So if we have two results with scores for name, exe name and desc as {55,30,12} and {45,30,65}, we would want the first result to show up rather than the second because the name seems to be a closer match. However, rn we are just taking the max so the second result would be higher in priority. Probably something like compare the name scores, if both are the same, go to exe scores, if they are the same then go to the description. Any thoughts? |
I think like if query starts with the name, it should be a higher score. Term here should be ranked higher since it is the start, not a fuzzy |
So I looked at the scores, |
@alekhyareddy28 : Taking the space into account sounds good! Two remarks:
|
There is a similar issue when searching for "power". The first match is rather odd, followed by better matches. I have it set to show 6 matches). (Using 0.18.2)
Looking at the shortcut for Debuggable Package Manager... Target: C:\Windows\SysWOW64\WindowsPowerShell\v1.0\powershell.exe -NoExit -Command "& { Import-Module Appx; Import-Module .\AppxDebug.dll; Show-AppxDebug}" Comment: Microsoft Visual Studio Debuggable Package Manager PowerShell Session |
While matching applications, we take the exe name as well into consideration. However, in PR #4020 this was taken care of so that |
@alekhyareddy28 I suspected that was the case. I'm just not sure it's always the best move. As I think through how I would use this feature, and how I currently use the WIN-Launch and Win-Run tools, I see competing priorities that somehow need to be reconciled since this power toy feature seems to be blending the two existing tools to an extent. If I'm trying to launch a program that is likely on the start menu or in the list of programs, I generally will know it by its name, not the executable name. This also goes for shortcuts. In these cases, the executable name is much less important. If I'm trying to launch a command-line tool that may not have a shortcut or menu item, then I probably know it by the executable name and that should be given priority. There are a number of other competing cases as well, like currently running apps, frequently used apps/commands, etc. Given all of that, if I had to choose between giving executable name priority, program name priority, or giving them equal weight, I think I would come down on the side of giving priority to program name over executable name. Especially since that is what seems to be shown in the results list, regardless of what matched. |
@Blueric, agreed. We are working on that prioritization. However, it may not be ready by 0.19. Thank you for your feedback. |
Fixed in 0.19.0, please visit https://github.com/microsoft/PowerToys/releases/ for the latest release |
Environment
Steps to reproduce
term
Expected behavior
"Windows Terminal" (which has "term" in it) should be ranked higher than "Character Map" (which seems to be shown because of the "ter M")
Actual behavior
"Character Map" is ranked higher than "Windows Terminal"
Screenshots
The text was updated successfully, but these errors were encountered: