-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Unexpected priority of search results for 'term' #3874
Fix for Unexpected priority of search results for 'term' #3874
Conversation
if we're going to do a hotfix, this may not be a bad PR for that |
Thank you @crutkas for letting me know, really appreciate it. |
We’ll continue to flag stuff that could be of use. I think we all should get together and figure out plugin model too. |
That would be great and helpful. I agree, glad you are thinking the same too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ex (microsoft#3874) (cherry picked from commit a8d67a1)
* Add resource only when it is not already present (#3842) (cherry picked from commit d2dfbff) * Take space into consideration while calculating the first matched index (#3874) (cherry picked from commit a8d67a1) * Fix for File explorer not showing up and multiple notepads (#3969) * reverted the dedup code, file explorer shows up but so do duplicates * Fixed file explorer and dedup * Formatting * Added tests for all the cases * Formatting * Tests * take name and exe into consideration while calculating hash * unique primes while calculating hash code (cherry picked from commit 8cddd59)
Summary of the Pull Request
Take space into consideration while calculating the first matched index.
PR Checklist
Detailed Description of the Pull Request / Additional comments
term
was showing up CharacterMap before Windows Terminal because the first match index in terminal was 8 whereas it was 6 for characterMap.Validation Steps Performed