Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT Run] WebApps can't be run as admin via program plugin #4604

Closed
htcfreek opened this issue Jun 30, 2020 · 13 comments
Closed

[PT Run] WebApps can't be run as admin via program plugin #4604

htcfreek opened this issue Jun 30, 2020 · 13 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Jun 30, 2020

For WebApps we should remove the "run as admin" button because it doesn't work. You can not run we apps/pinned web sites as admin.

Update (2020-10-01)

@royvou has found the cause of the bug and will fix it in a PR.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 30, 2020
@crutkas crutkas added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Jun 30, 2020
@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

start menu allows it
image

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 30, 2020
@crutkas crutkas added this to the v1.0 Release milestone Jun 30, 2020
@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

Adding this to .21 milestone so we don't lose the work tracking

@htcfreek
Copy link
Collaborator Author

Don't have tested it via start menu. But for me via PT Run it doesn't work. 🤔

@crutkas
Copy link
Member

crutkas commented Jun 30, 2020

is your PWA chrome based or Edgium based?

@htcfreek
Copy link
Collaborator Author

"Edgium"

In start menu Pinned Website/PWA opens. But I don't know if it has admin rights.
In PowerToys the normal browser UI with start page opens instead of the PWA/pinned website.

@crutkas
Copy link
Member

crutkas commented Jul 1, 2020

so i can launch both via admin rights. I just don't know if it matters really. validating if this should be correct behavior no matter what

@htcfreek
Copy link
Collaborator Author

htcfreek commented Jul 5, 2020

Here is a gif of the repo.
PT_run_website_admin

@htcfreek
Copy link
Collaborator Author

htcfreek commented Jul 7, 2020

Here is a gif of the repo.
PT_run_website_admin

Small hint:
The UAC is showing and agreed with yes. But this isn't captured in the gif.

@htcfreek
Copy link
Collaborator Author

Not fixed in 0.20!

@crutkas crutkas modified the milestones: v1.0 Release, InVEST-2009 Aug 26, 2020
@crutkas crutkas added the Help Wanted We encourage anyone to jump in on these and submit a PR. label Aug 26, 2020
@saahmedm saahmedm modified the milestones: InVEST-2009, v1.0 Release Sep 1, 2020
@crutkas crutkas modified the milestones: v1.0 Release, Help Wanted Sep 12, 2020
@htcfreek
Copy link
Collaborator Author

htcfreek commented Oct 1, 2020

Update to the issue:

  • Still exists in v0.23.0
  • Only happens when running the application. But not when running the lnk file.

@P-Storm, @royvou
Is this the same problem which we have in issue 6916?

@P-Storm
Copy link
Contributor

P-Storm commented Oct 1, 2020

I don't know for sure, I think @royvou could better tell if it is the same problem as #6916

@royvou
Copy link
Contributor

royvou commented Oct 1, 2020

It's a seperate issue (it is because the way the program / shell menus are built differently, so the root cause is the same).
I will add that to my other PR #6923 which will Change the way both start arguments are generated :)

@htcfreek htcfreek changed the title [PT Run] Remove "RunAsAdmin" Button for WebApps [PT Run] WebApps can't be run as admin via program plugin Oct 1, 2020
@htcfreek htcfreek added the Status-In progress This issue or work-item is under development label Oct 13, 2020
@crutkas crutkas added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Oct 21, 2020
@crutkas
Copy link
Member

crutkas commented Oct 29, 2020

In the 0.25 release. https://github.com/microsoft/PowerToys/releases/tag/v0.25.0

@crutkas crutkas closed this as completed Oct 29, 2020
@github-project-automation github-project-automation bot moved this to ⚠️Needs Walkthrough in 3. Help Wanted Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Status: ⚠️Needs Walkthrough
Development

No branches or pull requests

5 participants