Enable starting apps with command line arguments when run as admin is selected #6923
Conversation
…sStartInfo fixes missing LnkResolvedPath missing in contextmenu (E.g. Shortcuts / PWA's).
|
this change broke the unit tests |
|
(Hmmm Github should notify me for that, @crutkas thanks for the headsup!) The file is checked in now and running :) |
|
@royvou |
It is ready! |
|
@somil55, @ryanbodrug-microsoft |
|
|
||
| namespace Microsoft.Plugin.Program | ||
| { | ||
| internal class SearchResult |
There was a problem hiding this comment.
I think it would be better to make ProgramArguments part of Result class. SearchResult here seems to have the same meaning as Result. @ryanbodrug-microsoft Thoughts ?
There was a problem hiding this comment.
My reasoning for not doing that was I did not want to change any of the wox namespaces, it was my fist idea as well. But it is something to consider.
There was a problem hiding this comment.
@royvou It is fine to make changes in wox namespace. And I feel this would be a cleaner way to do this.
There was a problem hiding this comment.
Will update the PR later this week !
There was a problem hiding this comment.
Just a note the PR is updated 👍
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
LGTM! Thanks for this PR @royvou |
Summary of the Pull Request
This enables the command line arguments to also be passed to the "Run as admin" command, and also unifies both methods to create ProcessStartInfo which fixes another bug.
Implementations follows the same logic as Microsoft.Plugin.Folder where the state is maintained in the Result.ContextData Property (That way we also don't need to extend any of the Wox.* Projects).
PR Checklist
Info on Pull Request
See summary, fixes the issue mentioned in #6916 which was a feature not implemented / overseen at #5791.
Validation Steps Performed
wt -- ping 1.1.1.1 -t