Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run][Plugin Manager] Plugin management section (enable / disable, ...) #5273

Closed
htcfreek opened this issue Jul 28, 2020 · 45 comments
Closed
Assignees
Labels
Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Manager Issues with the PowerToys Run plugin manager

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Jul 28, 2020

We have different plugins for PowerToys Run and there are several issue where people asking for new plugins. Also we have no concept of integrating the settings for some plugins.

Here are my ideas with some additional descriptions. Please note that the mock ups are no real xaml windows. The are made with Word and Paint.

The back arrow on the sub pages is for navigating back to the parent page.
While giving the user the ability to disable plugins, they can define which types of results they wan't to see in the result list.

CRUTKAS addition from #6770

For PT Run, we need a way to manage plugins

  • enable / disable
  • add additional weight multiplier
  • set action keyword
  • Key shortcut to autolaunch directly like an action keyword

This should be dynamically loaded as well so when new plugins are added in, or a 3rd party plugin is there, it continues to work.

HTCFREEK added 2020-09-30

  • Maybe it is possible to define the order of results by sorting the plugins. This means if I order the WindowWalker plugin above the Program plugin, the open Windows will be shown first in the results.

Images (from HTCFREEK)

Plugin section on main page

Maybe we can use a sub item in navigation view fo access the plugin management page.

image


image
If no plugins are enabled the section looks like this.

Sub page with plugin list

image
The default plugins which are installed with PT Run are non-removable!


image

image


image
If all plugins are disabled you will see this message.

Sub page where the user can manage a plugin

image


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jul 28, 2020
@htcfreek
Copy link
Collaborator Author

htcfreek commented Jul 28, 2020

Improvements for users with many plugins

Search field for plugin list

If we have many plugins it would be interesting to have a search field between page title and plugin list.

image

Import plugin section

If the user has many plugins installed it's not relay nice if he has to scroll down the long list to import an new plugin. Maybe it's better to have an import plugin section at the top of the page.

image


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@niels9001
Copy link
Contributor

niels9001 commented Aug 12, 2020

@htcfreek. I really like the concepts and how it reflects how Windows 10 Settings does these things!

It does introduce some complexity with multiple views etc. with a lot of functionality that might not be there in a first version. I wonder if something like this would suffice for a quick v1.

Basically listing all plug-ins that come with PT Run out-of-the-box with the possibility to turn them on or off with a switch?

Here's a mock of what that would look like:

image

This is based on the Apps & Websites W10 Settings page:

image

@crutkas is Plug-in management on the roadmap for V1? Or a V2 activity?

@htcfreek
Copy link
Collaborator Author

@crutkas is Plug-in management on the roadmap for V1? Or a V2 activity?

I think for the first step (v1) it's okay if only enable/disable works.

The other things need more work in fronted and backend. So I think we won't get it in for v1.

@crutkas
Copy link
Member

crutkas commented Aug 12, 2020

I think it is something we'd like to do but not on roadmap. I feel like more and more we need it

@crutkas
Copy link
Member

crutkas commented Aug 12, 2020

namely around the web search stuff

@htcfreek
Copy link
Collaborator Author

htcfreek commented Sep 23, 2020

How about just a UI scaler? It seems pretty big for me. I'd like to be able to 50% size it to get more search results on-screen

These are design and functionality ideas. They are realized as images with image software. - So the proportions not final and maybe a bit incorrect.

@crutkas crutkas added Product-PowerToys Run Improved app launch PT Run (Win+R) Window Product-Settings The standalone PowerToys Settings application Run-Plugin Things that relate with PowerToys Run's plugin interface and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 23, 2020
@crutkas crutkas changed the title [Settings UX; PowerToys Run] Plugin management - UI mock ups [PT Run] Plugin management section (enable / disable, ...) Sep 23, 2020
@gordonwatts
Copy link
Contributor

This would (eventually) provide a UI for adjusting the keyboard filter shortcuts - which is one big thing my pr #6129 is missing.

@htcfreek
Copy link
Collaborator Author

This would (eventually) provide a UI for adjusting the keyboard filter shortcuts - which is one big thing my pr #6129 is missing.

Yes. I have missed this setting in my concept images.

@enricogior
Copy link
Contributor

@htcfreek
we should open individual issues for future enhancement, and close this one and #9655.

@htcfreek
Copy link
Collaborator Author

@htcfreek
we should open individual issues for future enhancement, and close this one and #9655.

I agree. Let's do this when 0.33 is released.

@htcfreek
Copy link
Collaborator Author

@enricogior
All the new issues for each of the remaining remaining enhancement ideas in this issue are created. (I didn't create any issue for ideas which regarding 3rd-Party-Plugin features.)

@enricogior
Copy link
Contributor

@htcfreek
great work! Thanks.

@enricogior enricogior added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Manager Issues with the PowerToys Run plugin manager and removed Status-In progress This issue or work-item is under development Run-Plugin Things that relate with PowerToys Run's plugin interface labels Feb 27, 2021
@crutkas
Copy link
Member

crutkas commented Mar 4, 2021

Great news! This was resolved in the newly released 0.33 version of PowerToys! Head to https://aka.ms/installpowertoys to grab latest.

@crutkas crutkas closed this as completed Mar 4, 2021
@garrulinae
Copy link

Awesome, great work! Where is the weighting/ordering feature now being tracked? This issue and #3271 and #3371 are all closed.

@crutkas
Copy link
Member

crutkas commented Mar 5, 2021

We were waiting on feedback for weight to see if this was enough. It adds a lot of complexity for debugging with community

@enricogior
Copy link
Contributor

@crutkas @garrulinae
the weighting algorithm was not working because of a bug, the initial request to allow manual weighting was assuming that the algorithm was working but not good enough.

For ordering, I think we should open a new issue since now that the plugin manager has been implemented, we can propose a specific UI for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cost-Large Large work item - 3+ days worth of work (chances are needs to be broken down) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Manager Issues with the PowerToys Run plugin manager
Projects
None yet
Development

No branches or pull requests

10 participants