Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode to full name, disable Visual Studio Code plugin by default #10071

Merged
merged 4 commits into from
Mar 8, 2021
Merged

VSCode to full name, disable Visual Studio Code plugin by default #10071

merged 4 commits into from
Mar 8, 2021

Conversation

mykhailopylyp
Copy link
Contributor

@mykhailopylyp mykhailopylyp commented Mar 5, 2021 •
edited
Loading

Summary of the Pull Request

What is this about:
image

What is include in the PR:

How does someone test / validate:

  • delete PowerToys Run\settings.json file
  • start PowerToys
  • Check that the Visual Studio Code Workspaces plugin is disabled

Quality Checklist

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@mykhailopylyp mykhailopylyp added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Mar 5, 2021
@enricogior
Copy link
Contributor

@niels9001
ideas for an icon for Visual Studio Code workspaces?

@enricogior
Copy link
Contributor

@mykhailopylyp

image

let's rename VSCode to VS Code since VSCode is not an official abbreviation.

@enricogior enricogior added Run-Plugin Things that relate with PowerToys Run's plugin interface Run-Plugin Manager Issues with the PowerToys Run plugin manager and removed Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels Mar 5, 2021
@niels9001
Copy link
Contributor

@niels9001
ideas for an icon for Visual Studio Code workspaces?

A bit generic, but could work:

image

Or just a monochrome version of the Visual Studio logo?

@htcfreek
Copy link
Collaborator

htcfreek commented Mar 5, 2021

@mykhailopylyp
How do we order the plugins?

@enricogior
Copy link
Contributor

@htcfreek
it's something we should implement, we were discussing it in #5273 (comment)

@enricogior
Copy link
Contributor

@niels9001
thanks! I think it's good for now.

@mykhailopylyp
can you add the icon in this PR?

@htcfreek
Copy link
Collaborator

htcfreek commented Mar 5, 2021

@htcfreek
it's something we should implement, we were discussing it in #5273 (comment)

As I understand you want to use the order to define the result prio.

@enricogior
Copy link
Contributor

@htcfreek

As I understand you want to use the order to define the result prio.

Yes. Ordering the plugins in the plugin manager would make sense if that order is also the order of priority in the results.

@htcfreek
Copy link
Collaborator

htcfreek commented Mar 5, 2021 •
edited
Loading

@htcfreek

As I understand you want to use the order to define the result prio.

Yes. Ordering the plugins in the plugin manager would make sense if that order is also the order of priority in the results.

Otherwise I thought we do it simply alphabetical. That's why I asked.

@niels9001
Copy link
Contributor

@enricogior @mykhailopylyp

Here are the icon assets (using the same dimensions and size as the other plugins), both .dark and .light

visualstudio dark

visualstudio light

@htcfreek
Copy link
Collaborator

htcfreek commented Mar 5, 2021

@mykhailopylyp

image

let's rename VSCode to VS Code since VSCode is not an official abbreviation.

Should be Opens and I think something is grammatically wrong.

@mykhailopylyp
Copy link
Contributor Author

mykhailopylyp commented Mar 5, 2021 •
edited
Loading

@niels9001 @htcfreek
After all, we use a glyph for VS Code plugin

@enricogior
Copy link
Contributor

@mykhailopylyp
Niels posted two PNGs, the first is not really visible in github, but it's there ;)

@mykhailopylyp
Copy link
Contributor Author

Niels posted two PNGs, the first is not really visible in github, but it's there

I used them.

htcfreek
htcfreek suggested changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better description suggestion.

Can you please post a pick of the expanded vs code plugin entry. Want to check something.

...s/launcher/Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/Properties/Resources.resx Outdated
</data>
<data name="In" xml:space="preserve">
<value>in</value>
<comment>Used to indicate the location where something is</comment>
</data>
<data name="PluginDescription" xml:space="preserve">
<value>Open VSCode previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value>
<value>Opens VS Code's previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value>
Copy link
Collaborator

@htcfreek htcfreek Mar 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<value>Opens VS Code's previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value>
<value>Lists and opens workspaces, remote machines (SSH or Codespaces) and containers, previously opened in VS Code.</value>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htcfreek
good suggestion.
Do we need Lists and... or can we just says Opens... since all modules, in a way or in another, lists something.

Copy link
Collaborator

@htcfreek htcfreek Mar 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htcfreek
good suggestion.
Do we need Lists and... or can we just says Opens... since all modules, in a way or in another, lists something.

@enricogior
Good point. To open them, I logical need a list. We could use only opens or we could use something like Provides access to ... which implies list and open too.

The important point that bothers me at the moment is, that in our productive description something seems to be/sounds wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go just with Opens as it is consistent with other plugins.

@htcfreek htcfreek mentioned this pull request Mar 5, 2021
Closed
@mykhailopylyp
Copy link
Contributor Author

@htcfreek

Can you please post a pick of the expanded vs code plugin entry. Want to check something.

Updated description.

htcfreek
htcfreek approved these changes Mar 8, 2021
View reviewed changes
Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

enricogior
enricogior approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge it!

@mykhailopylyp mykhailopylyp merged commit c36b202 into microsoft:master Mar 8, 2021
enricogior pushed a commit that referenced this pull request Mar 26, 2021
@mykhailopylyp @enricogior
VSCode to full name, disable Visual Studio Code plugin by default (#1…
a0c0f0a 
…0071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricogior enricogior enricogior approved these changes

@htcfreek htcfreek htcfreek approved these changes

Assignees
No one assigned
Labels
Run-Plugin Manager Issues with the PowerToys Run plugin manager Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykhailopylyp @enricogior @niels9001 @htcfreek