Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode to full name, disable Visual Studio Code plugin by default #10071

Merged
merged 4 commits into from
Mar 8, 2021
Merged

VSCode to full name, disable Visual Studio Code plugin by default #10071

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0630445
VSCode to full name, disable Visual Studio Code plugin by default
mykhailopylyp Mar 5, 2021
fb4949d
pr comments
mykhailopylyp Mar 5, 2021
2e7ad72
fix build, fix messages
mykhailopylyp Mar 5, 2021
ac57ed1
fix vs code description
mykhailopylyp Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion installer/PowerToysSetup/Product.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,8 @@
<?endforeach?>
</Component>
<Component Id="VSCodeWorkspacesImagesComponent" Directory="VSCodeWorkspaceImagesFolder" Guid="6F3C0CF1-7024-4333-BFA1-850D340AEE69">
<File Id="VSCodeWorkspacePluginIcon" Source="$(var.BinX64Dir)modules\launcher\Plugins\VSCodeWorkspaces\Images\vscode_plugin.png" />
<File Id="VSCodeWorkspaceCodeLight" Source="$(var.BinX64Dir)modules\launcher\Plugins\VSCodeWorkspaces\Images\code-light.png" />
<File Id="VSCodeWorkspaceCodeDark" Source="$(var.BinX64Dir)modules\launcher\Plugins\VSCodeWorkspaces\Images\code-dark.png" />
<File Id="VSCodeWorkspaceFolder" Source="$(var.BinX64Dir)modules\launcher\Plugins\VSCodeWorkspaces\Images\folder.png" />
<File Id="VSCodeWorkspaceRemote" Source="$(var.BinX64Dir)modules\launcher\Plugins\VSCodeWorkspaces\Images\monitor.png" />
</Component>
Expand Down
5 changes: 4 additions & 1 deletion ...erToys.Run.Plugin.VSCodeWorkspaces/Community.PowerToys.Run.Plugin.VSCodeWorkspaces.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@
<None Update="Images\monitor.png">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Images\vscode_plugin.png">
<None Update="Images\code-dark.png">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Update="Images\code-light.png">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
Expand Down
Binary file added ...er/Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/Images/code-dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...r/Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/Images/code-light.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed ...lugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/Images/vscode_plugin.png
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions .../Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions ...auncher/Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/Properties/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,14 @@
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="PluginTitle" xml:space="preserve">
<value>VSCode Workspaces</value>
<value>Visual Studio Code Workspaces</value>
</data>
<data name="In" xml:space="preserve">
<value>in</value>
<comment>Used to indicate the location where something is</comment>
</data>
<data name="PluginDescription" xml:space="preserve">
<value>Open VSCode previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value>
<value>Opens VS Code's previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value>
Copy link
Collaborator

@htcfreek htcfreek Mar 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<value>Opens VS Code's previously opened workspaces, remote machines (SSH or Codespaces) and containers.</value>
<value>Lists and opens workspaces, remote machines (SSH or Codespaces) and containers, previously opened in VS Code.</value>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htcfreek
good suggestion.
Do we need Lists and... or can we just says Opens... since all modules, in a way or in another, lists something.

Copy link
Collaborator

@htcfreek htcfreek Mar 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@htcfreek
good suggestion.
Do we need Lists and... or can we just says Opens... since all modules, in a way or in another, lists something.

@enricogior
Good point. To open them, I logical need a list. We could use only opens or we could use something like Provides access to ... which implies list and open too.

The important point that bothers me at the moment is, that in our productive description something seems to be/sounds wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go just with Opens as it is consistent with other plugins.

</data>
<data name="SSHRemoteMachine" xml:space="preserve">
<value>SSH remote machine</value>
Expand All @@ -142,4 +142,4 @@
<value>Workspace</value>
<comment>It refers to the "Visual Studio Code workspace"</comment>
</data>
</root>
</root>
8 changes: 4 additions & 4 deletions src/modules/launcher/Plugins/Community.PowerToys.Run.Plugin.VSCodeWorkspaces/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"ID": "525995402BEF4A8CA860D92F6D108092",
"Disabled": true,
"ActionKeyword": "{",
"Name": "VSCode Workspaces",
"Description": "Opened VSCode Workspaces",
"Name": "VS Code Workspaces",
"Author": "ricardosantos9521",
"Version": "1.0.0",
"Language": "csharp",
"Website": "https://github.com/ricardosantos9521/PowerToys/",
"ExecuteFileName": "Community.PowerToys.Run.Plugin.VSCodeWorkspaces.dll",
"IsGlobal": false,
"IcoPathDark": "Images\\vscode_plugin.png",
"IcoPathLight": "Images\\vscode_plugin.png"
"IcoPathDark": "Images\\code-dark.png",
"IcoPathLight": "Images\\code-light.png"
}