Localize PowerRename #1106
Merged
Localize PowerRename #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alekhyareddy28
added
Area-Localization
yuyoyuppe
suggested changes
Jan 17, 2020
bzoz
reviewed
Jan 17, 2020
bzoz
reviewed
Jan 17, 2020
bzoz
reviewed
Jan 17, 2020
bzoz
reviewed
Jan 17, 2020
bzoz
reviewed
Jan 17, 2020
bzoz
reviewed
Jan 17, 2020
|
The branch seems to be few commits behind master and there were some changes made in the PowerRename files in #1101 |
…ion instead which returns a wstring typecast into wchar*
yuyoyuppe
approved these changes
Jan 20, 2020
bzoz
reviewed
Jan 20, 2020
|
@alekhyareddy28 |
|
Hi Enrico,
Yes, I am really sorry for the inconvenience. I shall use the squash and
merge option from next time.
Thank you,
Regards
Alekhya
…On Mon, Jan 20, 2020 at 1:25 PM Enrico Giordani ***@***.***> wrote:
@alekhyareddy28 <https://github.com/alekhyareddy28>
in the future, please don't use the "Create a merge commit" option,
instead follow the Github Workflow
<https://github.com/microsoft/PowerToys/tree/master/doc/devdocs#github-workflow>
indication and use either Squash and merge or Rebase and merge, thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1106?email_source=notifications&email_token=AG3INCWG2ONOQ7MCFLWWY2DQ6YJGJA5CNFSM4KH3MENKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJN3E5Y#issuecomment-576434807>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG3INCXQP3MPKOCEKWKJXGLQ6YJGJANCNFSM4KH3MENA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This pull request is to localize the PowerRename Project. All the hardcoded strings from the PowerRename projects are moved to resource script files.
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
All hardcoded strings have been moved out to the .rc (resource script files) of each project. Wrappers have been implemented to extract these resources from the string tables of the resource script files.
Validation Steps Performed