[PowerToys Run] Disable module on windows startup #11684
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
We disable the PT Run module if the PT Run process fails to start. In this PR we make it more robust. For some users, the process can not be started because the shell window is not available yet, and
GetShellWindow()
returns null. We've seen it happen on windows starup. So we should recover ifGetShellWindow()
fails. Take into account that we only use the shell window to start unelevated PT Run from elevated PT.What is include in the PR:
GetShellWindow()
returns nullHow does someone test / validate:
Can be tested artificially. Try to fail
GetShellWindow()
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.