Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSIX: hide the "Run at Startup" option if running as packaged #1174

Merged
merged 1 commit into from
Jan 29, 2020
Merged

MSIX: hide the "Run at Startup" option if running as packaged #1174

merged 1 commit into from
Jan 29, 2020

Conversation

yuyoyuppe
Copy link
Collaborator

@yuyoyuppe yuyoyuppe commented Jan 29, 2020 •
edited
Loading

Summary of the Pull Request

  • do not apply the option for packaged
  • add this.state.settings.general.packaged flag so we can filter other settings (e.g. admin/elevation-related) using it
  • add condition to not show the option in settings-web

PR Checklist

Validation Steps Performed

  • Launched packaged and non-packaged versions of PT and verified that the feature is working
  • Enabled/Disabled the setting from the non-packaged version
  • All unit tests passed

@yuyoyuppe yuyoyuppe requested a review from bzoz January 29, 2020 12:00
@yuyoyuppe yuyoyuppe merged commit ca20343 into microsoft:master Jan 29, 2020
@yuyoyuppe yuyoyuppe deleted the issue_1163 branch January 29, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricogior enricogior enricogior approved these changes

@bzoz bzoz bzoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuyoyuppe @enricogior @bzoz