-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ready for Review - [MouseJump] move "common" classes into separate project #34333
base: main
Are you sure you want to change the base?
Ready for Review - [MouseJump] move "common" classes into separate project #34333
Conversation
… the checks # Conflicts: # src/modules/MouseUtils/MouseJump.Common.UnitTests/MouseJump.Common.UnitTests.csproj
# Conflicts: # src/modules/MouseUtils/MouseJump.Common.UnitTests/MouseJump.Common.UnitTests.csproj
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
So it looks like adding I'm not keen on it as a fix as MouseJump.Common only really needs a reference to |
# Conflicts: # PowerToys.sln
I think this PR is ready for review now - the manual and automated tests all work and the build pipeline is green. The only remaining piece of work is to incorporate the new "MouseJump.Common.dll" assembly into the installer. I'm not super-confident about what is required for that - would someone from the core team be able to help? |
Summary of the Pull Request
This is an attempt to break PR #33486 ([Mouse Jump] - Customisable appearance - borders, margins, colours) down into smaller chunks because it's gotten unmanageable due to its age and number of commits (currently 37 commits / 205 files changed and 25 merge conflicts).
This PR just moves the files in the "MouseJumpUI\Common" folder into a separate *.csproj project so that it can eventually be referenced by the SettingsUI project to draw a sample preview image when style settings are changed. There's no functionality changes in the code, just a move of the existing classes into a separate project (and updating the namespaces), so it'll hopefully be a lot easier to review than #33486, which can eventually be cancelled.
A separate follow-up PR will re-implement the Settings UI changes to close PR #33486 and Issue #27511.
PR Checklist
Detailed Description of the Pull Request / Additional comments
This PR moves all of the code currently held in the MouseJumpUI project under "src\modules\MouseUtils\MouseJumpUI\Common" into a new project "MouseJump.Common". This will allow the project to be referenced from the SettingsUI project in a follow-up PR as part of the work to implement customisable style settings.
Validation Steps Performed
Hotkey and size settings are automatically reloaded when config file is modified manually (e.g. in notepad) while runner and MouseJumpUI.exe are running