Fix for Camera App not showing up

[alekhyareddy28]

Summary of the Pull Request

This was happening because of the way the resource was passed to the SHLoadIndirectString function.
For some apps like Camera, the resource is LensSDK/Resources/AppTitle whereas for most other applications it is just AppTitle or AppDescription and the code was written such that the resources keyword would be prefixed. However, this does not work when there is a namespace with Resources already defined like in the case of the Camera app.
Due to this the DisplayName and Description were not being retrived and hence the app was not displayed. Another app for which this was happening on my system is XBox Console companion.

References

• https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-shloadindirectstring?redirectedfrom=MSDN

PR Checklist

• Applies to No camera in run #3532 (Parent tracking item - [Launcher, Tracker] doesn't find some apps (file explorer, windows terminal,...) #3223)
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

• If the word resource is present in the DisplayName parameter of the Appmanifest.xml file, we do not add an extra resource string.

Validation Steps Performed

• The camera app shows up now.
  
• Set breakpoints where exceptions were thrown when the SHLoadIndirectString function returned an hresult other than S_OK and verified that all those cases are now solved, which was Camera and Xbox Companion console apps in my case.

[crutkas]

we hit this cause we removed that random unsigned dll?

[alekhyareddy28]

No this is not related to that dll. The way the code was adding the string resource to get teh DisplayName was incorrect. Due to that we were getting an empty DisplayName and description leading to the app not showing up.

[dsrivastavv]

I am unable to see camera app in wox as well. This issue was there since we inherited their codebase. We can contribute this change back to wox as well.

[crutkas]

if they haven't fixed the issue, lets prep a PR for them

[crutkas]

@jjw24 and @bao-qian, this change may be helpful for your code bases.

[crutkas]

if we're going to do a hotfix, this may not be a bad PR for that

[dsrivastavv]

LGTM!