P1614R2 Spaceship: Clause 27: Time (partial, pre-C++20 types)

[statementreply]

This PR patches pre-C++20 <chrono> types.

#323 has already implemented WG21-P1614 for the new calendar types.

[MattStephanson]

I had implemented these for utc_clock et al. I don't mind waiting, just FYI that this is blocking other work.

[statementreply]

I had implemented these for utc_clock et al. I don't mind waiting, just FYI that this is blocking other work.

Would it be better if I retarget this PR to main branch to unblock <chrono> work?

[MattStephanson]

Oh, I forgot there's a feature branch for these. I'm using operator<=>(leap_second,sys_time) (thus, operator<=>(time_point,time_point)) for std::get_leap_second_info, so it would be useful for me to have it. But I could also rewrite it and move the leap-related <=> to feature/spaceship as well.

[statementreply]

Force-pushed, retarget to main.

[StephanTLavavej]

Looks great! I'll push a test.lst update.

[StephanTLavavej]

I've mirrored this to internal MSVC-PR-305171.

Please note: Further changes are still possible (e.g. if you notice something, or if final review leads to more feedback that should be addressed before merging), but they must be replicated to the mirror PR in order to avoid codebase divergence.

[StephanTLavavej]

Thanks for implementing these timeships and unblocking further work on C++20 timezones! ⏲️ 🛸 😺