-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<chrono> Partially implement P0355R7 #323
Conversation
Maybe I should have squashed the commits 👀 Edit: decided to squash them as they added a lot of noise to the conversation. Surprised GitHub doesn't collapse them or something. |
tests/std/tests/P0355R7_calendars_and_time_zones_dates/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P0355R7_calendars_and_time_zones_dates/test.cpp
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This reverts commit 72b2583. Already tested by P0355R7_calendars_and_time_zones_dates_literals.
Thanks for implementing a huge part of this huge C++20 feature, and for enduring over a year (!!!) of review! 😻 📅 📆 🚀 🎉 |
And thanks for enduring my sometimes questionable code 😅. One thing though, is this one not an "issue"? #323 (comment) |
Thanks, missed that outstanding issue - basically, we're not super duper disciplined about our |
Description
Partially implemented #12;
[time.point.arithmetic] and [time.cal] (excluding I/O)
I've used a couple of Howard's algorithms, which I hope is okay as it's public domain
I originally used Howard's algorithm forI did eventually realise this was just a result of poor reading comprehension on my end.year_month_day::operator sys_days()
but I just saw LWG3206 in the issue thread and switched to it however it broke my test project's uses ofconstexpr
due to the depth limit.Speaking of
constexpr
I had to disable the warning for negative integral => unsigned as uses of it in constexpr contexts fail to compile. No idea if that was the correct thing to do.There is more than likely a better way of doing
year_month_weekday::operator sys_days() const
than how I implemented it. edit: I believe I've improved this.During testing I found that this code triggers an ICE
I think everything should be
noexcept /* strengthened */
? If so are they applied to declarations, definitions, or both?Checklist
Be sure you've read README.md and understand the scope of this repo.
If you're unsure about a box, leave it unchecked. A maintainer will help you.
_Ugly
as perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before automated testing is enabled on GitHub,
leave this unchecked for initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft (including any cited standards), other WG21 papers
(excluding reference implementations outside of proposed standard wording),
and LWG issues as reference material. If they were derived from a project
that's already listed in NOTICE.txt, that's fine, but please mention it.
If they were derived from any other project (including Boost and libc++,
which are not yet listed in NOTICE.txt), you must mention it here,
so we can determine whether the license is compatible and what else needs
to be done.