-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement P0448R4 spanstream #2029
Conversation
Co-authored-by: Matt Stephanson <[email protected]>
Co-authored-by: Adam Bucior <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review (to be available as a video recording in the near future), I looked at everything except stl/inc/spanstream
and P0448R4_spanstream/test.cpp
.
Co-authored-by: Stephan T. Lavavej <[email protected]>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Video reviewed basic_spanbuf
and the recent commits; basic_ispanstream
and below, and the new test, remain. (This is a lot of code, thanks for working on it! 😻)
Co-authored-by: Stephan T. Lavavej <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Charlie Barto <[email protected]>
@miscco I pushed changes to use variable templates in the test as @barcharcraz suggested. It's slightly fewer lines of source code, and avoids emitting function calls (which isn't a big deal in test code, but can make stepping through a bit nicer). I also took this opportunity to rename |
I'm mirroring this to the MSVC-internal repo now. Please notify me if any further changes are pushed. |
Thanks for continuing to implement a stream of |
This implements spanstream that was recently voted into C++23
Fixes #1970