Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P0448R4 spanstream #2029

Merged
merged 35 commits into from
Sep 11, 2021
Merged

Implement P0448R4 spanstream #2029

merged 35 commits into from
Sep 11, 2021

Commits on Jun 30, 2021

  1. Implement spanstream 

    Fixes microsoft#1970
    @miscco
    miscco committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    e94ce25 View commit details
    Browse the repository at this point in the history

  2. Move aliases into iosfwd

    @miscco
    miscco committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    3d12c64 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2021

  1. Address review comments 

    Co-authored-by: Matt Stephanson <[email protected]>
    @miscco @MattStephanson
    miscco and MattStephanson committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    e9dee40 View commit details
    Browse the repository at this point in the history

  2. Add iosfwd test in sync with C++23

    @miscco
    miscco committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    40edba9 View commit details
    Browse the repository at this point in the history

  3. Address review comments 

    Co-authored-by: Adam Bucior <[email protected]>
    @miscco @AdamBucior
    miscco and AdamBucior committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    e59ac94 View commit details
    Browse the repository at this point in the history

  4. More review comments

    @miscco
    miscco committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    95643a5 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Merge branch 'main' into spanstream

    @miscco
    miscco committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    5b413fb View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    Co-authored-by: Stephan T. Lavavej <[email protected]>
    @miscco @StephanTLavavej
    miscco and StephanTLavavej committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    ff35037 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Merge branch 'main' into spanstream

    @miscco
    miscco committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    1537a09 View commit details
    Browse the repository at this point in the history

  2. uNstreampos is defined in xstring

    @miscco
    miscco committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    ef50108 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Merge branch 'main' into spanstream

    @miscco
    miscco committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    822de91 View commit details
    Browse the repository at this point in the history

  2. Address review comments 

    Co-authored-by: Stephan T. Lavavej <[email protected]>
    @miscco @StephanTLavavej
    miscco and StephanTLavavej committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    3ed6a02 View commit details
    Browse the repository at this point in the history

  3. Add tests for const buffer

    @miscco
    miscco committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    c61afd8 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Merge branch 'main' into spanstream

    @StephanTLavavej
    StephanTLavavej committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    2587e4c View commit details
    Browse the repository at this point in the history

  2. Work around DevCom-1511903. 

    Also, this test can assume that concepts are available.
    @StephanTLavavej
    StephanTLavavej committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    b1650ea View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Merge branch 'main' into spanstream

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    92ec9c3 View commit details
    Browse the repository at this point in the history

  2. Add comment about _STD span.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    76c7c7b View commit details
    Browse the repository at this point in the history

  3. Private typedefs.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    e7b10b2 View commit details
    Browse the repository at this point in the history

  4. Call member swap().

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    d03004d View commit details
    Browse the repository at this point in the history

  5. Mark rdbuf() and span() as _NODISCARD.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    8b309e3 View commit details
    Browse the repository at this point in the history

  6. Always qualify _STD span.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    d57fc0a View commit details
    Browse the repository at this point in the history

  7. Assignment needs to return *this;.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    d0ec9af View commit details
    Browse the repository at this point in the history

  8. Comment nitpick: "member functions".

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    a2a4923 View commit details
    Browse the repository at this point in the history

  9. Drop this-> for rdbuf().

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    3134d3f View commit details
    Browse the repository at this point in the history

  10. basic_ospanstream and basic_spanstream need to return span<_Elem>.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    862f03d View commit details
    Browse the repository at this point in the history

  11. Include more headers in the test.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    8cad51f View commit details
    Browse the repository at this point in the history

  12. Fix comment typo.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    31bca31 View commit details
    Browse the repository at this point in the history

  13. Avoid test_buf shadowing.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    5257648 View commit details
    Browse the repository at this point in the history

  14. Rename basic_ospanstream to os.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    1b5d100 View commit details
    Browse the repository at this point in the history

  15. test_spanstream() should use basic_spanstream named s.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    5116294 View commit details
    Browse the repository at this point in the history

  16. Fix test: basic_spanstream can't be constructed from `span<const Ch… 

    …arT>`.
    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    205178e View commit details
    Browse the repository at this point in the history

  17. Comment: _Baseoff is always non-negative.

    @StephanTLavavej
    StephanTLavavej committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    d40f1ee View commit details
    Browse the repository at this point in the history

  18. Add test that the returned span is indeed mutable

    @miscco
    miscco committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    34e426c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. Delete the (unintentionally re-added) vcpkg submodule.

    @StephanTLavavej
    StephanTLavavej committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    7130829 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Use variable templates in the test. 

    Co-authored-by: Charlie Barto <[email protected]>
    @StephanTLavavej @barcharcraz
    StephanTLavavej and barcharcraz committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    f57ff9f View commit details
    Browse the repository at this point in the history