Remove SHOUTY banners #2072
Remove SHOUTY banners #2072
Conversation
stl/src/wlocale.cpp
Outdated
| @@ -1,7 +1,6 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
|
|
|||
| // class locale wide member functions | |||
There was a problem hiding this comment.
I'm not sure if this is SHOUTY or useless
There was a problem hiding this comment.
Urgh, not sure how that happened.
Might redo with keener eyes.
stl/src/xlocale.cpp
Outdated
| @@ -1,7 +1,6 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
|
|
|||
| // class locale exotic char member functions | |||
There was a problem hiding this comment.
I'm not sure if this is SHOUTY or useless
| @@ -21,12 +21,10 @@ _STL_DISABLE_CLANG_WARNINGS | |||
| #pragma push_macro("new") | |||
| #undef new | |||
| _STD_BEGIN | |||
| // CLASS TEMPLATE _Tset_traits | |||
| template <class _Kty, // key/value type | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Lesson learned I guess. Look at what VS Code actually replaces with 😅.
stl/inc/set
Outdated
| using _Alnode = typename _Mybase::_Alnode; | ||
| using _Alnode_traits = typename _Mybase::_Alnode_traits; | ||
| // ordered red-black tree of key values, unique keys | ||
| public : static_assert(!_ENFORCE_MATCHING_ALLOCATORS || is_same_v<_Kty, typename _Alloc::value_type>, |
There was a problem hiding this comment.
This does not make sense
There was a problem hiding this comment.
I think VS Code might not have liked replacing so many....
(to note, I did audit the previews for each file before replacing)
There was a problem hiding this comment.
it is still not resolved
| @@ -1,7 +1,6 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
|
|
|||
| // class locale member functions | |||
There was a problem hiding this comment.
Same, not sure if this should be removed
stl/src/locale0.cpp
Outdated
| @@ -1,7 +1,6 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
|
|
|||
| // class locale basic member functions | |||
There was a problem hiding this comment.
Same, not sure if this should be removed
| @@ -33,7 +33,6 @@ inline constexpr char _Charconv_digits[] = {'0', '1', '2', '3', '4', '5', '6', ' | |||
| 'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z'}; | |||
| static_assert(_STD size(_Charconv_digits) == 36); | |||
|
|
|||
| // FUNCTION to_chars (INTEGER TO STRING) | |||
There was a problem hiding this comment.
Should the INTEGER TO STRING (and other ones) part be kept?
|
Urgh, didn't realise that would close. I just wanted to rename my branch :( |
Fixes #306
Not fully done yet but this should be all of the major ones.
Should some remain like this one?
STL/stl/inc/atomic
Lines 105 to 109 in bd7adb4
P.S. Good luck with the review. 🙏