Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SHOUTY banners #2072

Closed
wants to merge 10 commits into from
Closed

Remove SHOUTY banners #2072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f6cc8bd
Remove CLASS
SuperWig Jul 22, 2021
03a8884
Remove FUNCTION
SuperWig Jul 22, 2021
204321c
Remove PARALLEL FUNCTION
SuperWig Jul 22, 2021
40f553e
Remove ENUM
SuperWig Jul 22, 2021
686bd67
Remove STRUCT
SuperWig Jul 22, 2021
8900bb7
Remove CONSTRUCT
SuperWig Jul 22, 2021
8b5d098
Remove VARIABLE
SuperWig Jul 22, 2021
09d8654
Some fixes
SuperWig Jul 22, 2021
ae05deb
Fix set
SuperWig Jul 22, 2021
96fb3db
Clean up "defined in <xstddef>" comments.
SuperWig Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
165 changes: 1 addition & 164 deletions stl/inc/algorithm
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions stl/inc/any
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ _STL_DISABLE_CLANG_WARNINGS

_STD_BEGIN

// CLASS bad_any_cast
class bad_any_cast : public bad_cast { // thrown by failed any_cast
public:
_NODISCARD virtual const char* __CLR_OR_THIS_CALL what() const noexcept override {
Expand Down Expand Up @@ -108,7 +107,6 @@ template <class _Ty>
inline constexpr _Any_small_RTTI _Any_small_RTTI_obj = {
&_Any_small_RTTI::_Destroy_impl<_Ty>, &_Any_small_RTTI::_Copy_impl<_Ty>, &_Any_small_RTTI::_Move_impl<_Ty>};

// CLASS any
class any { // storage for any (CopyConstructible) type
public:
// Construction and destruction [any.cons]
Expand Down
4 changes: 0 additions & 4 deletions stl/inc/array
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ _STL_DISABLE_CLANG_WARNINGS
#undef new

_STD_BEGIN
// CLASS TEMPLATE _Array_const_iterator
#if _ITERATOR_DEBUG_LEVEL != 0
struct _Iterator_base12_compatible { // TRANSITION, for binary compatibility
_Container_proxy* _Myproxy{};
Expand Down Expand Up @@ -327,7 +326,6 @@ struct pointer_traits<_Array_const_iterator<_Ty, _Size>> {
};
#endif // _HAS_CXX20

// CLASS TEMPLATE _Array_iterator
template <class _Ty, size_t _Size>
class _Array_iterator : public _Array_const_iterator<_Ty, _Size> {
public:
Expand Down Expand Up @@ -433,7 +431,6 @@ struct pointer_traits<_Array_iterator<_Ty, _Size>> {
};
#endif // _HAS_CXX20

// CLASS TEMPLATE array
template <class _Ty, size_t _Size>
class array { // fixed size array of values
public:
Expand Down Expand Up @@ -850,7 +847,6 @@ _NODISCARD _CONSTEXPR20 bool operator>=(const array<_Ty, _Size>& _Left, const ar
#endif // ^^^ !defined(__cpp_lib_concepts) ^^^

#if _HAS_CXX20
// FUNCTION TEMPLATE to_array
template <class _Ty, size_t _Size, size_t... _Idx>
_NODISCARD constexpr array<remove_cv_t<_Ty>, _Size> _To_array_lvalue_impl(
_Ty (&_Array)[_Size], index_sequence<_Idx...>) {
Expand Down
18 changes: 0 additions & 18 deletions stl/inc/atomic
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ _END_EXTERN_C
#endif

_STD_BEGIN
// STRUCT TEMPLATE _Storage_for
#if _CMPXCHG_MASK_OUT_PADDING_BITS
struct _Form_mask_t {};
_INLINE_VAR constexpr _Form_mask_t _Form_mask{};
Expand Down Expand Up @@ -201,21 +200,18 @@ extern "C" inline void atomic_signal_fence(const memory_order _Order) noexcept {
}
}

// FUNCTION TEMPLATE kill_dependency
template <class _Ty>
_Ty kill_dependency(_Ty _Arg) noexcept { // "magic" template that kills dependency ordering when called
return _Arg;
}

// FUNCTION _Check_memory_order
inline void _Check_memory_order(const memory_order _Order) noexcept {
// check that _Order is a valid memory_order
if (static_cast<unsigned int>(_Order) > static_cast<unsigned int>(memory_order_seq_cst)) {
_INVALID_MEMORY_ORDER;
}
}

// FUNCTION _Check_store_memory_order
inline void _Check_store_memory_order(const memory_order _Order) noexcept {
switch (_Order) {
case memory_order_relaxed:
Expand All @@ -232,7 +228,6 @@ inline void _Check_store_memory_order(const memory_order _Order) noexcept {
}
}

// FUNCTION _Check_load_memory_order
inline void _Check_load_memory_order(const memory_order _Order) noexcept {
switch (_Order) {
case memory_order_relaxed:
Expand All @@ -249,7 +244,6 @@ inline void _Check_load_memory_order(const memory_order _Order) noexcept {
}
}

// FUNCTION _Combine_cas_memory_orders
_NODISCARD inline memory_order _Combine_cas_memory_orders(
const memory_order _Success, const memory_order _Failure) noexcept {
// Finds upper bound of a compare/exchange memory order
Expand Down Expand Up @@ -282,7 +276,6 @@ _NODISCARD inline memory_order _Combine_cas_memory_orders(
return _Combined_memory_orders[static_cast<int>(_Success)][static_cast<int>(_Failure)];
}

// FUNCTION TEMPLATE _Atomic_reinterpret_as
template <class _Integral, class _Ty>
_NODISCARD _Integral _Atomic_reinterpret_as(const _Ty& _Source) noexcept {
// interprets _Source as the supplied integral type
Expand All @@ -298,7 +291,6 @@ _NODISCARD _Integral _Atomic_reinterpret_as(const _Ty& _Source) noexcept {
}
}

// FUNCTION _Load_barrier
inline void _Load_barrier(const memory_order _Order) noexcept { // implement memory barrier for atomic load functions
switch (_Order) {
case memory_order_relaxed:
Expand All @@ -324,7 +316,6 @@ struct _Atomic_padded {
};

#else // ^^^ don't break ABI / break ABI vvv
// STRUCT TEMPLATE _Atomic_storage_traits
template <class _Ty>
struct _Atomic_storage_traits { // properties for how _Ty is stored in an atomic
static constexpr size_t _Storage_size = sizeof(_Ty) == 1 ? 1
Expand All @@ -346,7 +337,6 @@ struct _Atomic_storage_traits<_Ty&> { // properties for how _Ty is stored in an
static constexpr bool _Uses_padding = false;
};

// STRUCT TEMPLATE _Atomic_padded
template <class _Ty, bool = _Atomic_storage_traits<_Ty>::_Uses_padding>
struct _Atomic_padded { // aggregate to allow explicit constexpr zeroing of padding
alignas(_Atomic_storage_traits<_Ty>::_Storage_size) mutable _Ty _Value;
Expand Down Expand Up @@ -377,7 +367,6 @@ struct _Atomic_storage_types<_Ty&> {
using _Spinlock = _Smtx_t*; // POINTER TO mutex
};

// STRUCT TEMPLATE _Atomic_storage
#if 1 // TRANSITION, ABI
template <class _Ty, size_t = sizeof(remove_reference_t<_Ty>)>
#else // ^^^ don't break ABI / break ABI vvv
Expand Down Expand Up @@ -1325,7 +1314,6 @@ struct _Atomic_storage<_Ty&, 16> { // lock-free using 16-byte intrinsics
};
#endif // _WIN64

// STRUCT TEMPLATE _Atomic_integral
template <class _Ty, size_t = sizeof(_Ty)>
struct _Atomic_integral; // not defined

Expand Down Expand Up @@ -1659,7 +1647,6 @@ _INLINE_VAR constexpr bool _Deprecate_non_lock_free_volatile = true;
template <class _Ty>
_CXX20_DEPRECATE_VOLATILE _INLINE_VAR constexpr bool _Deprecate_non_lock_free_volatile<_Ty, false> = true;

// STRUCT TEMPLATE _Atomic_integral_facade
template <class _Ty>
struct _Atomic_integral_facade : _Atomic_integral<_Ty> {
// provides operator overloads and other support for atomic integral specializations
Expand Down Expand Up @@ -1793,7 +1780,6 @@ struct _Atomic_integral_facade : _Atomic_integral<_Ty> {
}
};

// STRUCT TEMPLATE _Atomic_integral_facade
template <class _Ty>
struct _Atomic_integral_facade<_Ty&> : _Atomic_integral<_Ty&> {
// provides operator overloads and other support for atomic integral specializations
Expand Down Expand Up @@ -1989,7 +1975,6 @@ struct _Atomic_floating<_Ty&> : _Atomic_storage<_Ty&> {
};
#endif // _HAS_CXX20

// STRUCT TEMPLATE _Atomic_pointer
template <class _Ty>
struct _Atomic_pointer : _Atomic_storage<_Ty> {
using _Base = _Atomic_storage<_Ty>;
Expand Down Expand Up @@ -2092,7 +2077,6 @@ struct _Atomic_pointer : _Atomic_storage<_Ty> {
};


// STRUCT TEMPLATE _Atomic_pointer
template <class _Ty>
struct _Atomic_pointer<_Ty&> : _Atomic_storage<_Ty&> {
using _Base = _Atomic_storage<_Ty&>;
Expand Down Expand Up @@ -2153,7 +2137,6 @@ struct _Atomic_pointer<_Ty&> : _Atomic_storage<_Ty&> {
};


// STRUCT TEMPLATE atomic
#define ATOMIC_VAR_INIT(_Value) \
{ _Value }

Expand Down Expand Up @@ -2840,7 +2823,6 @@ using atomic_signed_lock_free = atomic_intptr_t;
using atomic_unsigned_lock_free = atomic_uintptr_t;
#endif // _HAS_CXX20

// STRUCT atomic_flag
#define ATOMIC_FLAG_INIT \
{}
struct atomic_flag { // flag with test-and-set semantics
Expand Down
3 changes: 0 additions & 3 deletions stl/inc/bitset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ _STL_DISABLE_CLANG_WARNINGS
#undef new

_STD_BEGIN
// CLASS TEMPLATE bitset
template <size_t _Bits>
class bitset { // store fixed-length sequence of Boolean elements
public:
Expand All @@ -28,7 +27,6 @@ public:
using _Ty = conditional_t<_Bits <= sizeof(unsigned long) * CHAR_BIT, unsigned long, unsigned long long>;
#pragma warning(pop)

// CLASS reference
class reference { // proxy for an element
friend bitset<_Bits>;

Expand Down Expand Up @@ -556,7 +554,6 @@ basic_istream<_Elem, _Tr>& operator>>(basic_istream<_Elem, _Tr>& _Istr, bitset<_
return _Istr;
}

// STRUCT TEMPLATE SPECIALIZATION hash
template <size_t _Bits>
struct hash<bitset<_Bits>> {
_CXX17_DEPRECATE_ADAPTOR_TYPEDEFS typedef bitset<_Bits> _ARGUMENT_TYPE_NAME;
Expand Down
7 changes: 0 additions & 7 deletions stl/inc/charconv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ inline constexpr char _Charconv_digits[] = {'0', '1', '2', '3', '4', '5', '6', '
'f', 'g', 'h', 'i', 'j', 'k', 'l', 'm', 'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w', 'x', 'y', 'z'};
static_assert(_STD size(_Charconv_digits) == 36);

// FUNCTION to_chars (INTEGER TO STRING)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the INTEGER TO STRING (and other ones) part be kept?

template <class _RawTy>
_NODISCARD to_chars_result _Integer_to_chars(
char* _First, char* const _Last, const _RawTy _Raw_value, const int _Base) noexcept {
Expand Down Expand Up @@ -205,7 +204,6 @@ inline to_chars_result to_chars(char* const _First, char* const _Last, const uns
to_chars_result to_chars(char* _First, char* _Last, bool _Value, int _Base = 10) = delete;


// STRUCT from_chars_result
struct from_chars_result {
const char* ptr;
errc ec;
Expand All @@ -214,7 +212,6 @@ struct from_chars_result {
#endif // _HAS_CXX20
};

// FUNCTION from_chars (STRING TO INTEGER)
_NODISCARD inline unsigned char _Digit_from_char(const char _Ch) noexcept {
// convert ['0', '9'] ['A', 'Z'] ['a', 'z'] to [0, 35], everything else to 255
static constexpr unsigned char _Digit_from_byte[] = {255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
Expand Down Expand Up @@ -1643,9 +1640,6 @@ _NODISCARD errc _Convert_hexadecimal_string_to_floating_type(

// ^^^^^^^^^^ DERIVED FROM corecrt_internal_strtox.h ^^^^^^^^^^


// FUNCTION from_chars (STRING TO FLOATING-POINT)

// C11 6.4.2.1 "General"
// digit: one of
// 0 1 2 3 4 5 6 7 8 9
Expand Down Expand Up @@ -2060,7 +2054,6 @@ inline from_chars_result from_chars(const char* const _First, const char* const
return _Result;
}

// FUNCTION to_chars (FLOATING-POINT TO STRING)
template <class _Floating>
_NODISCARD to_chars_result _Floating_to_chars_hex_precision(
char* _First, char* const _Last, const _Floating _Value, int _Precision) noexcept {
Expand Down
Loading