Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untag dispatch find_first_of #2479

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Untag dispatch find_first_of #2479

merged 2 commits into from
Mar 19, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Towards #189

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner January 15, 2022 15:44
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Jan 16, 2022
StephanTLavavej
StephanTLavavej approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@StephanTLavavej StephanTLavavej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I like the approach you've chosen, and taking care of find_first_of in a small PR, so this can be applied to the following algorithms in later PR(s).

@CaseyCarter CaseyCarter self-assigned this Feb 23, 2022
CaseyCarter
CaseyCarter approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix pushed.

stl/inc/xstring Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Mar 16, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 18, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c221b34 into microsoft:main Mar 19, 2022
@StephanTLavavej
Copy link
Member

Thanks for this series of great PRs! 🐱 🐈 🐈‍⬛

@AlexGuteniev AlexGuteniev deleted the untag_dispatch_find_again branch March 19, 2022 09:55
@StephanTLavavej StephanTLavavej mentioned this pull request Mar 19, 2022
Open
AlexGuteniev added a commit to AlexGuteniev/STL that referenced this pull request Apr 21, 2022
@AlexGuteniev
Untag dispatch <xstring>
25c40ec 
Same as microsoft#2479, nothing to see here
@AlexGuteniev AlexGuteniev mentioned this pull request Apr 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter