Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untag dispatch <xstring> #2660

Merged
merged 5 commits into from
May 1, 2022
Merged

Untag dispatch <xstring> #2660

merged 5 commits into from
May 1, 2022

Conversation

AlexGuteniev
Copy link
Contributor

Towards #189

Same as #2479, nothing to see here

@AlexGuteniev
Untag dispatch <xstring>
25c40ec 
Same as microsoft#2479, nothing to see here
@AlexGuteniev AlexGuteniev requested a review from a team as a code owner April 21, 2022 17:16
@CaseyCarter CaseyCarter added the enhancement Something can be improved label Apr 21, 2022
@StephanTLavavej StephanTLavavej added throughput Must compile faster and removed enhancement Something can be improved labels Apr 21, 2022
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@AlexGuteniev

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Apr 27, 2022
@StephanTLavavej StephanTLavavej mentioned this pull request Apr 28, 2022
Open
@StephanTLavavej StephanTLavavej removed their assignment Apr 28, 2022
@StephanTLavavej
Copy link
Member

Looks great, thanks for the continued if constexprization!

I pushed a trivial change to remove // general algorithm comments (matching your previous _Traits_find_first_of() change) - these were the counterparts of the // special case for std::char_traits comments, and both are no longer necessary now that there's a clear if constexpr (_Special) { ... } else { ... }.

Note to reviewers: as before, GitHub makes this diff look way worse than it really is. I copied each pair of old and new implementations into VS Code editors, then reordered the old overloads so that the "special" case occurs first. Along with a bit of indentation, this made the diff easy to read.

@StephanTLavavej StephanTLavavej self-assigned this Apr 30, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit a10c471 into microsoft:main May 1, 2022
@StephanTLavavej
Copy link
Member

Thanks for completing the untag dispatching of <xstring>'s find functions and improving throughput! 🚀 🐇 ⏱️

@AlexGuteniev AlexGuteniev deleted the untag_dispatch_string_find branch May 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexGuteniev @StephanTLavavej @CaseyCarter @raghavthind2005