-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various cleanups #2595
Merged
StephanTLavavej
merged 25 commits into
microsoft:main
from
StephanTLavavej:cleanup-stuff
Mar 19, 2022
Merged
Various cleanups #2595
StephanTLavavej
merged 25 commits into
microsoft:main
from
StephanTLavavej:cleanup-stuff
Mar 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for consistency - they're equivalent, but we should use the more "modern" form.
Suggested by AlexGuteniev - we have no intention of salvaging these tests. If we wanted better coverage in these areas, we'd write new tests from scratch.
Followup to GH 2147.
…to printf. This allows the compiler to detect type mismatches.
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
requested changes
Mar 1, 2022
This test is for C++17 and above. Clang 10 added support for C++20 constinit, so we can drop the special case here. (We don't need special coverage for C++17 specifically here.)
cpplearner
reviewed
Mar 2, 2022
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
CaseyCarter
approved these changes
Mar 2, 2022
tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
Thanks to @cpplearner for noticing this. Coroutines are usually C++20 but are also activated by `/await:strict`, so we permanently need to check `__cpp_impl_coroutine` - this is not a temporary thing until Clang 14 is released. (Tests that are C++20-specific can be simplified after Clang 14, so they still have TRANSITION comments.) Finally, we should also add a new configuration to `VSO_0157762_feature_test_macros`.
These configurations were unused after GH 752 "Remove compiler specific feature test macro tests".
CaseyCarter
approved these changes
Mar 2, 2022
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
statements.__analysis_assume
to_Analysis_assume_
.<algorithm>
: Fix an unpaired// clang-format off
after_Generate_n_fn
.<complex>
: Centralize on using_STD
instead of::std::
.<complex>
: Remove unnecessary_STD
qualification on an_Ugly
function,_Log_abs()
.<limits>
: Remove unnecessary qualification ofstd::numeric_limits
.<locale>
: Remove unnecessary defenses for macroizedisalnum
etc.<cctype>
: do not defend against isalnum/etc. macros #2147.<random>
: Use range-for._Val
, as_Elem
is almost always a template parameter here.<random>
: Improve formatting of_Refill_lower()
.<random>
: Slightly simplify loop in_Small_poisson_distribution::operator()
.return
instead ofbreak
followed byreturn
. (There's no other way to exit this loop.)_Res
to the loop, making its counting behavior even clearer.<ranges>
: Use extendedfriend
syntax.<yvals_core.h>
: Cite<cuchar>
:mbrtoc8()
andc8rtomb()
are not yet implemented #2207 formbrtoc8()
andc8rtomb()
.<yvals_core.h>
: Remove dead macro_STL_WIN32_WINNT_WINXP
.GH_001411_core_headers/test.compile.pass.cpp
.// COMPILE-ONLY
test.P0912R5_coroutine/test.cpp
: Simplify__cpp_lib_coroutine
test.STL/stl/inc/yvals_core.h
Lines 1257 to 1259 in ff54450
P0980R1_constexpr_strings/test.cpp
: Attach a brace totest_gh_2524()
.VSO_0102478_moving_allocators/test.cpp
: Pass format strings directly toprintf
.tr1
tests.P0083R3_splicing_maps_and_sets/test.cpp
: Drop special case for Clang.constinit
, so we can drop the special case here. (We don't need special coverage for C++17 specifically here.)// TRANSITION, Clang 14 coroutine support
.P0912R5_coroutine/env.lst
: Add MSVC/EDG C++20 and Clang C++23 coverage./await:strict
./await:strict
, so we permanently need to check__cpp_impl_coroutine
- this is not a temporary thing until Clang 14 is released. (Tests that are C++20-specific can be simplified after Clang 14, so they still have TRANSITION comments.) Finally, we should also add a new configuration toVSO_0157762_feature_test_macros
.VSO_0157762_feature_test_macros/env.lst
: Remove unused configurations.If desired, I can split this into smaller PRs, but I believe that the changes are simple enough to be reviewed in a single PR.