Remove compiler specific feature test macro tests #752
Conversation
|
|
|
Hi Jonathan! I see that you signed the CLA so the bot is happy. As a Microsoft employee, you should link your GitHub account to your Microsoft alias and then join the Microsoft organization; the instructions are at https://docs.opensource.microsoft.com/tools/github/accounts/linking.html (Microsoft-internal link). You need to have 2FA set up for GitHub; after that, the process is easy and fast. After following those steps, Microsoft should appear in the lower-left Organizations section of your profile https://github.com/JonCavesMSFT ; you can see mine at https://github.com/StephanTLavavej for reference. |
|
You're now displayed as a member of the Microsoft organization - yay! 😺 |
|
For anyone reading this PR, the backstory is: the STL's test suite is for testing the STL, not testing compilers (directly). When I took the unusual step of implementing feature-test macros in both the STL and the MSVC compiler (except for However, moving STL development to GitHub has made this compiler test coverage problematic. Now, when the MSVC compiler implements a C++20 feature with a feature-test macro, we have to deal with the fact that the tests on GitHub use the latest public VS Preview, which contains compiler sources that are older than the freshly-built compiler used to run the tests in our Microsoft-internal compiler/STL repo. By moving the compiler feature-test macro tests alongside the other compiler tests, we'll avoid this maintenance headache. |
There was a problem hiding this comment.
Looks good - we'll merge this when we see MSVC-PR-244874 merge.
|
Congratulations on your first open-source contribution to the STL! |
s/to the STL// :) |
Compilers should test their own feature-test macros so the STL need not do so.
This PR removes compiler specific feature test macro tests: these tests have been moved to the C++ compiler test suite.