Fix non-deterministic test sharding with --order=lexical
#2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
infrastructure
cpplearner
approved these changes
Jun 16, 2022
CaseyCarter
approved these changes
Jun 16, 2022
miscco
approved these changes
Jun 16, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
I compared the logs for this CI run and the following run (which had no test additions/removals). Their x64 3 shards ran exactly the same tests with exactly the same results (slightly different times of course), verifying that this works in practice (and not just on the same physical machine). |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2794, which silently degraded our test coverage.
Thanks to @CaseyCarter for investigating the bizarre symptoms and finding this documented option.