build and test infra cleanup #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Extract common pipeline config into a new `azure-devops/config.yml` variable template so we don't need to repeat pool info and target directories in both pipelines. * Improve the `displayName`s of all the pipeline stages. * Use `trigger: none` so ASan pipeline runs don't trigger for pushes to _any_ branch. We _do_ want to schedule a daily build, so add `schedules`. * `benchmarkBuildOutputLocationVar` was actually used to control building the benchmarks; replace with a boolean `buildBenchmarks`.` * We need to explicitly remove `asan-pipeline`'s second stage's dependency on the first with `dependsOn: []`. * We never set `buildOutputLocationVar` to a non-default value; get rid of it. * Make `litFlags` a defaulted parameter of `cmake-configure-build.yml` so we don't need to duplicate it. * Don't try to build the benchmarks if configuring the benchmarks fails.
CaseyCarter
added
infrastructure
CaseyCarter
commented
Oct 4, 2023
CaseyCarter
commented
Oct 4, 2023
CaseyCarter
commented
Oct 4, 2023
StephanTLavavej
approved these changes
Oct 5, 2023
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for setting up this daily ASan CI! I've updated the toolset checklist. ✅ 📆 🎉 |
Great, thanks. |
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
azure-devops/config.ymlvariable template so we don't need to repeat pool info and target directories in both pipelines.displayNames of all the pipeline stages.trigger: noneso ASan pipeline runs don't trigger for pushes to any branch. We do want to schedule a daily build, so addschedules.benchmarkBuildOutputLocationVarwas actually used to control building the benchmarks; replace with a booleanbuildBenchmarks.asan-pipeline's second stage's dependency on the first withdependsOn: [].buildOutputLocationVarto a non-default value; get rid of it.litFlagsa defaulted parameter ofcmake-configure-build.ymlso we don't need to duplicate it.--shuffle, which was overridden by--order=lexical; this should have been done in Fix non-deterministic test sharding with--order=lexical#2795.azure-devops/cmake-configure-build.yml.Reminder: We'll need to update https://github.com/microsoft/STL/wiki/Checklist-for-Toolset-Updates after this merges, the pool name now appears in
azure-devops/config.yml.