Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement P2520R0: move_iterator<T*> should be a random access iterator #2958

Merged
merged 6 commits into from
Aug 3, 2022
Merged

Implement P2520R0: move_iterator<T*> should be a random access iterator #2958

merged 6 commits into from
Aug 3, 2022

Conversation

strega-nil-ms
Copy link
Contributor

Fixes #2939

@strega-nil-ms strega-nil-ms requested a review from a team as a code owner July 27, 2022 18:33
@CaseyCarter CaseyCarter added the cxx23 C++23 feature label Jul 27, 2022
CaseyCarter
CaseyCarter requested changes Jul 27, 2022
View reviewed changes
stl/inc/xutility Outdated Show resolved Hide resolved
stl/inc/yvals_core.h Show resolved Hide resolved
@CaseyCarter CaseyCarter self-requested a review July 27, 2022 21:22
CaseyCarter
CaseyCarter approved these changes Jul 27, 2022
View reviewed changes
stl/inc/xutility Outdated Show resolved Hide resolved
@strega-nil-ms strega-nil-ms mentioned this pull request Jul 27, 2022
Merged
@CaseyCarter
Copy link
Member

CaseyCarter commented Jul 28, 2022 •
edited
Loading

The test runner has found the pertinent libc++ test that you'll need to skip.

CaseyCarter
CaseyCarter requested changes Jul 28, 2022
View reviewed changes
tests/libcxx/skipped_tests.txt Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter self-requested a review July 29, 2022 21:17
StephanTLavavej
StephanTLavavej reviewed Jul 30, 2022
View reviewed changes
stl/inc/xutility Outdated Show resolved Hide resolved
tests/std/tests/P0896R4_ranges_iterator_machinery/test.cpp Outdated Show resolved Hide resolved
tests/libcxx/expected_results.txt Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

@strega-nil-ms @CaseyCarter I pushed changes for two trivial nitpicks and one copy-pasta, FYI.

@StephanTLavavej StephanTLavavej mentioned this pull request Jul 30, 2022
Closed
@StephanTLavavej StephanTLavavej self-assigned this Aug 3, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 85f4639 into microsoft:main Aug 3, 2022
@StephanTLavavej
Copy link
Member

Thanks for implementing this C++23 feature and moving towards feature completeness! 📉 😹 🚀

@StephanTLavavej StephanTLavavej mentioned this pull request Aug 3, 2022
Merged
strega-nil added a commit to strega-nil/stl that referenced this pull request Aug 6, 2022
@strega-nil-ms @strega-nil @StephanTLavavej
Implement P2520R0: move_iterator<T*> should be a random access iter…
ceccbc8 
…ator (microsoft#2958)

Co-authored-by: Nicole Mazzuca <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
fsb4000 pushed a commit to fsb4000/STL that referenced this pull request Aug 13, 2022
@strega-nil-ms @strega-nil
@StephanTLavavej @fsb4000
Implement P2520R0: move_iterator<T*> should be a random access iter…
d5dd615 
…ator (microsoft#2958)

Co-authored-by: Nicole Mazzuca <[email protected]>
Co-authored-by: Stephan T. Lavavej <[email protected]>
@strega-nil-ms strega-nil-ms deleted the p2520 branch December 19, 2022 23:42
@fsb4000 fsb4000 mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja left review comments

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@miscco miscco miscco approved these changes

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
cxx23 C++23 feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2520R0 move_iterator<T*> Should Be A Random-Access Iterator
6 participants
@strega-nil-ms @CaseyCarter @StephanTLavavej @miscco @frederick-vs-ja @strega-nil