Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous Cleanups #3178

Merged
merged 10 commits into from
Oct 26, 2022
Merged

Miscellaneous Cleanups #3178

merged 10 commits into from
Oct 26, 2022

Commits on Oct 25, 2022

  1. basic_string::_Move_construct_from_substr already knows the allocator

    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    ab253ec View commit details
    Browse the repository at this point in the history

  2. Consistently guard _Verify_offset(-n) against -INT_MIN

    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    5c01c09 View commit details
    Browse the repository at this point in the history

  3. Cleanup _NOEXCEPT_IDL0 

    Make `transform_view::iterator::_Verify_offset` always `noexcept` by avoiding checks when the underlying iterator doesn't support `_Verify_offset`. Make that function and `elements_view::iterator::_Verify_offset` available only when `_IDL != 0` **fixing a bug in `elements_view::iterator`**. Remove the now unused `_NOEXCEPT_IDL0` machinery.

Fixes microsoft#1269
    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    82f8f86 View commit details
    Browse the repository at this point in the history

  4. Keep type and data member definitions together in <execution> 

    Fixes microsoft#330
    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    f8a9403 View commit details
    Browse the repository at this point in the history

  5. <system_error>: Correct if (!cond) x(); else y(); 

    ... to `if (cond) y(); else x();`

Drive-by: Let's `static_assert` only when running the test suite.
    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    4720604 View commit details
    Browse the repository at this point in the history

  6. tests/P2278R4_basic_const_iterator nitpicks 

    * Simplify nested requirement in `HasPeek`
* Remove excess empty line
    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    20e5872 View commit details
    Browse the repository at this point in the history

  7. tests/P2322R6_ranges_alg_fold: factor out non-dependent tests 

    ... from `instantiator::call`. Reduces compile + run time by 27%.
    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    0171915 View commit details
    Browse the repository at this point in the history

  8. _STL_INTERNAL_STATIC_ASSERT doesn't take a reason. Also split for cla… 

    …rity.
    @StephanTLavavej
    StephanTLavavej committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    0af41f5 View commit details
    Browse the repository at this point in the history

  9. Fixup transform_view death test 

    transform_view iterators are validated only when the underlying iterators are.
    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    310daee View commit details
    Browse the repository at this point in the history

  10. revert churn in views_transform_death

    @CaseyCarter
    CaseyCarter committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    948fad1 View commit details
    Browse the repository at this point in the history