Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The typings can only be a .d.ts file. Contact package author to fix it #5278

Closed
basarat opened this issue Oct 16, 2015 · 1 comment
Closed

The typings can only be a .d.ts file. Contact package author to fix it #5278

basarat opened this issue Oct 16, 2015 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 1.7.3

Comments

@basarat
Copy link
Contributor

basarat commented Oct 16, 2015

Happens when using the latest compiler as a language service. Sample package : csx https://github.com/basarat/csx npm install csx.

I suspect that #4911 broke it ... it now looks at the csx.ts file and errors 🌹
@basarat basarat mentioned this issue Oct 16, 2015
Closed
@basarat basarat changed the title The typings can only a .d.ts file. Contact package author to fix it The typings can only be a .d.ts file. Contact package author to fix it Oct 16, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Oct 21, 2015

yup. that would be a side effect of #4911. the fix would be to add the full extension in the typings field ("typings": "csx.d.ts").

We have got feedback about users wanting to include their .ts files and found the compiler changing its lookup rules to pick .d.ts files too restrictive.

We should remove the error though.

@mhegazy mhegazy added the Bug A bug in TypeScript label Oct 21, 2015
@mhegazy mhegazy added this to the TypeScript 1.7.3 milestone Oct 21, 2015
This was referenced Oct 21, 2015
Closed
Merged
@msklvsk msklvsk mentioned this issue Oct 24, 2015
Closed
@basarat basarat mentioned this issue Oct 26, 2015
Closed
@vladima vladima mentioned this issue Oct 26, 2015
Merged
@vladima vladima added the Fixed A PR has been merged for this issue label Oct 26, 2015
basarat added a commit to TypeStrong/atom-typescript that referenced this issue Oct 27, 2015
@basarat
chore(typescript) update to latest
26c874e 
needed for microsoft/TypeScript#5278
@mhegazy mhegazy mentioned this issue Nov 4, 2015
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 1.7.3
Development

No branches or pull requests
3 participants
@basarat @mhegazy @vladima