Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ignore-unrecognized-flags option #5393

Closed
re222dv opened this issue Oct 24, 2015 · 5 comments
Closed

Add --ignore-unrecognized-flags option #5393

re222dv opened this issue Oct 24, 2015 · 5 comments
Labels
Suggestion An idea for TypeScript

Comments

@re222dv
Copy link

re222dv commented Oct 24, 2015

Now that #5231 I have a hard time using the latest version.
Atom complains that I need the flag to use async/await but the compiler errors if I do.

A --ignore-unrecognized-flags would be nice so one could pass newly removed options until other tools have been updated.
@mhegazy
Copy link
Contributor

mhegazy commented Oct 26, 2015

The behavior is intentional to avoid having misspelled compiler options go unchecked.

In this specific case, we can put pack the flag as "known", but not require it, for a release or so, until all tools have moved on.

Before i do this, i would like to know what is the issue here, @basarat any idea why this would be an issue with atom? would that be something fixed by taking latest from master of release-1.7 branch.

@mhegazy mhegazy added the Needs More Info The issue still hasn't been fully clarified label Oct 26, 2015
@basarat
Copy link
Contributor

basarat commented Oct 26, 2015

would that be something fixed by taking latest from master of release-1.7 branch.

Yes definitely, mostly waiting on two bugs (linked here TypeStrong/atom-typescript#663) : #5278 (labeled as a bug needing fixing) & #5110 (not reproduced cause I don't have the test files ... so will probably update even without this)

@Pajn
Copy link

Pajn commented Oct 26, 2015

The behavior is intentional to avoid having misspelled compiler options go unchecked.

The default behaviour yes, but this is a request for a flag to circumvent this behaviour.
Even if this specific case is fixed, it will probably pop up again when other flags are removed. Having a flag that can be set in those cases would make it easier for everyone. You doesn't need to keep "ghost flags" around and we can workaround this kind of problems instead of rolling back the version.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 26, 2015

I understand the issue, but i do not think the proposed solution of a new flag solves it, it just hides the problem. We will get #5278 fixed today, and that will unblock @basarat. and moving on will take a a more gradual approach to removing flags to make sure non one runs into this again.

basarat added a commit to TypeStrong/atom-typescript that referenced this issue Oct 27, 2015
@basarat
chore(typescript) update to latest
db9c30a 
closes #663
refs microsoft/TypeScript#5393
refs #643 @tomitrescak hopefully this doesn't break your code. If it does a code sample would be great 🌹
@mhegazy mhegazy removed the Needs More Info The issue still hasn't been fully clarified label Nov 13, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Nov 13, 2015

We keep the original issue in mind in the future. we should have a better deprication story for flags. sorry for the trouble. but i believe now migrating to latest atom-typescript safely.

@mhegazy mhegazy closed this as completed Nov 13, 2015
@mhegazy mhegazy added the Suggestion An idea for TypeScript label Nov 13, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Pajn @basarat @re222dv @mhegazy