[#6446] TeamsInfo GetTeamChannelsAsync, GetTeamDetailsAsync don't pass along the cancellation token #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw-joelmut
added
the
Automation: No parity
Pull Request Test Coverage Report for Build 320084
💛 - Coveralls |
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll |
tracyboehrer
approved these changes
Sep 6, 2022
tracyboehrer
deleted the
southwork/add/teams-operations-cancellationtoken
branch
tracyboehrer
pushed a commit
that referenced
this pull request
Sep 7, 2022
tracyboehrer
added a commit
that referenced
this pull request
Sep 7, 2022
* Revert "[#6430] Adaptive ForEachElement does not exit when child action CancelAllDialogs is called (#6452)" (#6466) This reverts commit c572be3. Co-authored-by: Tracy Boehrer <[email protected]> * Add cancellation token to TeamsOperation class (#6458) * Fix typing indicator shown after bot has replied (#6460) Co-authored-by: Tracy Boehrer <[email protected]> Co-authored-by: Joel Mut <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6446
Description
This PR adds the cancellation token in the
TeamsOperationsclass methods to be passed in to theGetResponseAsyncmethod.Specific Changes
TeamsOperationsmethod, adding the cancellation token to theGetResponseAsyncmethod call.